Re: [PR] [FLINK-35287] Builder builds NetworkConfig for Elasticsearch connector 8 [flink-connector-elasticsearch]

2024-05-03 Thread via GitHub
liuml07 commented on code in PR #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100#discussion_r1588846145 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java: ## @@ -94,7 +94,

Re: [PR] [FLINK-35287] Builder builds NetworkConfig for Elasticsearch connector 8 [flink-connector-elasticsearch]

2024-05-03 Thread via GitHub
liuml07 commented on code in PR #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100#discussion_r1588846646 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java: ## @@ -108,7 +10

Re: [PR] [FLINK-35287] Builder builds NetworkConfig for Elasticsearch connector 8 [flink-connector-elasticsearch]

2024-05-03 Thread via GitHub
liuml07 commented on PR #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100#issuecomment-2093511191 @mtfelisb and @reswqa mind taking a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-35287] Builder builds NetworkConfig for Elasticsearch connector 8 [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
liuml07 commented on PR #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100#issuecomment-2123537876 @reswqa @MartijnVisser Could you help review? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-35287] Builder builds NetworkConfig for Elasticsearch connector 8 [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
reswqa merged PR #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu