Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-07-12 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1675726294 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/write/HiveOutputFormatFactory.java: ## @@ -43,19 +51,28 @@ public

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-07-12 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1675733139 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSource.java: ## @@ -60,7 +62,7 @@ */ @PublicEvolving public class

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-07-12 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1675726294 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/write/HiveOutputFormatFactory.java: ## @@ -43,19 +51,28 @@ public

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-07-12 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1675721067 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceBuilder.java: ## @@ -242,21 +249,33 @@ public HiveSource

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-07-12 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1675721067 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceBuilder.java: ## @@ -242,21 +249,33 @@ public HiveSource

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-07-12 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1675718687 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSource.java: ## @@ -60,7 +62,7 @@ */ @PublicEvolving public class

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-07-12 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1675715727 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/FileSystemLookupFunction.java: ## @@ -88,6 +94,7 @@ public

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on PR #24835: URL: https://github.com/apache/flink/pull/24835#issuecomment-2129222164 Shouldn't this pr go in after [https://github.com/apache/flink/pull/24618](https://github.com/apache/flink/pull/24618) -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1613118293 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageDataset.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1613112277 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageDataset.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1613106837 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageDataset.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1613096352 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageDataset.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24835: URL: https://github.com/apache/flink/pull/24835#discussion_r1613096352 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageDataset.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-23 Thread via GitHub
flinkbot commented on PR #24835: URL: https://github.com/apache/flink/pull/24835#issuecomment-2127917873 ## CI report: * e23f6d5c6a133afc8f7e8fadda7fbd64570c806f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-23 Thread via GitHub
HuangZhenQiu opened a new pull request, #24835: URL: https://github.com/apache/flink/pull/24835 ## What is the purpose of the change Implement LineageVertexProvider Interface for Hive connectors. ## Brief change log - implement LineageVertexProvider in hive source,