Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-29 Thread via GitHub
pnowojski closed pull request #24784: [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… URL: https://github.com/apache/flink/pull/24784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-28 Thread via GitHub
ldadima commented on PR #24784: URL: https://github.com/apache/flink/pull/24784#issuecomment-2136510387 > Thanks for the update @ldadima . I have fixed up a couple of things in #24857 so let me close this PR in favour of that one. Could you take a look at my version? I checked the MR

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-28 Thread via GitHub
pnowojski commented on PR #24784: URL: https://github.com/apache/flink/pull/24784#issuecomment-2135614198 Thanks for the update @ldadima . I have fixed up a couple of things in https://github.com/apache/flink/pull/24857 so let me close this PR in favour of that one. Could you take a look at

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-22 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1609545011 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(Ta

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-22 Thread via GitHub
ldadima commented on PR #24784: URL: https://github.com/apache/flink/pull/24784#issuecomment-2124300783 > ## CI report: > * [ca6f434](https://github.com/apache/flink/commit/ca6f43494af9f19bddba40487a90bc4cbfb2f5ff) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-22 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1609545011 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(Ta

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-21 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1609248919 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
ldadima commented on PR #24784: URL: https://github.com/apache/flink/pull/24784#issuecomment-2120974575 Sorry to bother you again, but I made a separate one [Pull request with hotfix](https://github.com/apache/flink/pull/24811) -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1607065866 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(Ta

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1607065866 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(Ta

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1607065866 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(Ta

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1607061596 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
pnowojski commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1606882746 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Soft

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
pnowojski commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1606820986 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-20 Thread via GitHub
pnowojski commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1606820986 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-19 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1606228058 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-19 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1606228058 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-19 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1606219365 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/recovery/RescalingStreamTaskNetworkInput.java: ## @@ -232,7 +232,9 @@ public Predicate> appl

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-19 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1606219365 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/recovery/RescalingStreamTaskNetworkInput.java: ## @@ -232,7 +232,9 @@ public Predicate> appl

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-17 Thread via GitHub
pnowojski commented on PR #24784: URL: https://github.com/apache/flink/pull/24784#issuecomment-2117031802 Also please note that azure is failing on some compilation issue. Probably some check style violation. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-17 Thread via GitHub
pnowojski commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1604531639 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/recovery/RescalingStreamTaskNetworkInput.java: ## @@ -232,7 +232,9 @@ public Predicate> ap

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-16 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1603118510 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-16 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1603118510 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-16 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1603118510 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-16 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1603115904 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-16 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1603115064 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/recovery/RescalingStreamTaskNetworkInput.java: ## @@ -232,7 +232,9 @@ public Predicate> appl

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-16 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1603110590 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(Ta

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-16 Thread via GitHub
pnowojski commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1602844798 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointCustomRescaleITCase.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Soft

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-16 Thread via GitHub
pnowojski commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1602832692 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-15 Thread via GitHub
ldadima commented on PR #24784: URL: https://github.com/apache/flink/pull/24784#issuecomment-2111794984 > ## CI report: > * [309cf5b](https://github.com/apache/flink/commit/309cf5b7c295a56527b71ac0a1869ce06cd3a244) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-14 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1600910971 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(Ta

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-14 Thread via GitHub
ldadima commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1600910971 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(Ta

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-14 Thread via GitHub
pnowojski commented on code in PR #24784: URL: https://github.com/apache/flink/pull/24784#discussion_r1599796750 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java: ## @@ -421,7 +423,27 @@ public void reDistributeInputChannelStates(

Re: [PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-14 Thread via GitHub
flinkbot commented on PR #24784: URL: https://github.com/apache/flink/pull/24784#issuecomment-2109757235 ## CI report: * 487dc362ac9f6d0b4b32f7545d4a1d7329de1342 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35351][checkpoint] Fix fail during restore from unaligned chec… [flink]

2024-05-14 Thread via GitHub
ldadima opened a new pull request, #24784: URL: https://github.com/apache/flink/pull/24784 ## What is the purpose of the change To fix [FLINK-35351](https://issues.apache.org/jira/browse/FLINK-35351) ## Verifying this change UnalignedCheckpointCustomRescaleITCase#restoreF