Zakelly closed pull request #24810: [FLINK-35355][State] Internal async
aggregating state and corresponding state descriptor
URL: https://github.com/apache/flink/pull/24810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Zakelly commented on PR #24810:
URL: https://github.com/apache/flink/pull/24810#issuecomment-2129836350
CI green, merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jectpro7 commented on PR #24810:
URL: https://github.com/apache/flink/pull/24810#issuecomment-2128688435
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Zakelly commented on PR #24810:
URL: https://github.com/apache/flink/pull/24810#issuecomment-2128382654
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jectpro7 commented on PR #24810:
URL: https://github.com/apache/flink/pull/24810#issuecomment-2127002060
@Zakelly, looks good now. Thanks for the reminder. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
jectpro7 commented on PR #24810:
URL: https://github.com/apache/flink/pull/24810#issuecomment-2126452493
@Zakelly, It looks weird, seems the git configuration is not correct. I will
fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Zakelly commented on PR #24810:
URL: https://github.com/apache/flink/pull/24810#issuecomment-2126218813
@jectpro7 Seems the author of this commit is different from the committer?
Do you mind change that? Or I can merge this as it is.
--
This is an automated message from the Apache Git Ser
jectpro7 commented on PR #24810:
URL: https://github.com/apache/flink/pull/24810#issuecomment-2126086682
Hi @Zakelly, I've addressed comments, please help double review. Thanks in
advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
jectpro7 commented on code in PR #24810:
URL: https://github.com/apache/flink/pull/24810#discussion_r1609184018
##
flink-runtime/src/test/java/org/apache/flink/runtime/state/v2/SumAggregator.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jectpro7 commented on code in PR #24810:
URL: https://github.com/apache/flink/pull/24810#discussion_r1608402571
##
flink-runtime/src/test/java/org/apache/flink/runtime/state/v2/SumAggregator.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Zakelly commented on code in PR #24810:
URL: https://github.com/apache/flink/pull/24810#discussion_r1606741087
##
flink-runtime/src/test/java/org/apache/flink/runtime/state/v2/SumAggregator.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jectpro7 commented on PR #24810:
URL: https://github.com/apache/flink/pull/24810#issuecomment-2120370181
Hi @Zakelly, Thanks for the comments, I have added a commit for addressing
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jectpro7 commented on code in PR #24810:
URL: https://github.com/apache/flink/pull/24810#discussion_r1606717423
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/v2/InternalAggregatingState.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation
jectpro7 commented on code in PR #24810:
URL: https://github.com/apache/flink/pull/24810#discussion_r1606715404
##
flink-runtime/src/test/java/org/apache/flink/runtime/state/v2/SumAggregator.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Zakelly commented on code in PR #24810:
URL: https://github.com/apache/flink/pull/24810#discussion_r1606319004
##
flink-runtime/src/test/java/org/apache/flink/runtime/state/v2/SumAggregator.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
flinkbot commented on PR #24810:
URL: https://github.com/apache/flink/pull/24810#issuecomment-2119250508
## CI report:
* febf64d82f15cf1916066709f69aa35a4eb43b25 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
jectpro7 opened a new pull request, #24810:
URL: https://github.com/apache/flink/pull/24810
This PR defines the V2 `AggreatingState` and its `StateDescriptor`. And
provides the default `InternalAggregatingState` implementation which delegates
all aycn request to AEC.
## What
17 matches
Mail list logo
