gaborgsomogyi merged PR #24919:
URL: https://github.com/apache/flink/pull/24919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gaborgsomogyi commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2164843469
I'm fine with merging it on 14th of June EOB. Let's wait on other voices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ammar-master commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2163411240
@gaborgsomogyi Can this go in before the feature freeze on June 15?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
gaborgsomogyi commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2162792331
Unless there are further comments I'm intended to merge it beginning of next
week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ammar-master commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2162158973
@gaborgsomogyi I have addressed the comment, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ammar-master commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2162158609
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gaborgsomogyi commented on code in PR #24919:
URL: https://github.com/apache/flink/pull/24919#discussion_r1634861389
##
flink-runtime/src/main/java/org/apache/flink/runtime/net/SSLUtils.java:
##
@@ -285,7 +291,14 @@ private static KeyManagerFactory getKeyManagerFactory(
gaborgsomogyi commented on code in PR #24919:
URL: https://github.com/apache/flink/pull/24919#discussion_r1634845033
##
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/CustomSSLEngineProvider.java:
##
@@ -59,13 +71,38 @@ public TrustManager[]
ammar-master commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2159778519
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ammar-master commented on code in PR #24919:
URL: https://github.com/apache/flink/pull/24919#discussion_r1634155084
##
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/CustomSSLEngineProvider.java:
##
@@ -59,13 +71,38 @@ public TrustManager[]
ammar-master commented on code in PR #24919:
URL: https://github.com/apache/flink/pull/24919#discussion_r1634154163
##
flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java:
##
@@ -148,6 +148,17 @@ void testRESTClientSSLWrongPassword(String sslProvider) {
ammar-master commented on code in PR #24919:
URL: https://github.com/apache/flink/pull/24919#discussion_r1634153986
##
flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java:
##
@@ -306,6 +341,19 @@ void testInternalSSLWrongKeyPassword(String sslProvider) {
ammar-master commented on code in PR #24919:
URL: https://github.com/apache/flink/pull/24919#discussion_r1634004521
##
docs/layouts/shortcodes/generated/security_configuration.html:
##
@@ -134,6 +134,12 @@
String
The secret to decrypt the keystore file
ammar-master commented on code in PR #24919:
URL: https://github.com/apache/flink/pull/24919#discussion_r1633910473
##
docs/layouts/shortcodes/generated/security_configuration.html:
##
@@ -134,6 +134,12 @@
String
The secret to decrypt the keystore file
gaborgsomogyi commented on code in PR #24919:
URL: https://github.com/apache/flink/pull/24919#discussion_r1633123484
##
flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java:
##
@@ -148,6 +148,17 @@ void testRESTClientSSLWrongPassword(String sslProvider) {
gaborgsomogyi commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2158109164
Please have a look at the failing test:
```
Jun 10 07:17:02 07:17:02.965 [INFO] Running
org.apache.flink.docs.configuration.ConfigOptionsDocsCompletenessITCase
Jun 10
gaborgsomogyi commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2157658542
@ammar-master thanks for this PR, looks quality code from first glance
perspective. I'm going to shepherd it this week...
--
This is an automated message from the Apache Git
flinkbot commented on PR #24919:
URL: https://github.com/apache/flink/pull/24919#issuecomment-2157312543
## CI report:
* 14cf0fc58dfb9553ffe703622b6223a54549aacd UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
ammar-master opened a new pull request, #24919:
URL: https://github.com/apache/flink/pull/24919
## What is the purpose of the change
Additional configuration options for internal and REST SSL setup.
## Brief change log
* SSL configuration option for
master-ammar closed pull request #24918: [FLINK-35371][security] Add
configuration for SSL keystore and truststore type
URL: https://github.com/apache/flink/pull/24918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
flinkbot commented on PR #24918:
URL: https://github.com/apache/flink/pull/24918#issuecomment-2157270012
## CI report:
* db7977869fe099d7cf1cf428bec048e608dbdd60 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
master-ammar opened a new pull request, #24918:
URL: https://github.com/apache/flink/pull/24918
## What is the purpose of the change
Additional configuration options for internal and REST SSL setup.
## Brief change log
* SSL configuration option for
22 matches
Mail list logo
