Re: [PR] [FLINK-35457][checkpoint] Hotfix! close physical file under the protection of lock [flink]

2024-05-27 Thread via GitHub
fredia merged PR #24846: URL: https://github.com/apache/flink/pull/24846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35457][checkpoint] Hotfix! close physical file under the protection of lock [flink]

2024-05-27 Thread via GitHub
fredia commented on code in PR #24846: URL: https://github.com/apache/flink/pull/24846#discussion_r1616500402 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -131,19 +131,22 @@ public abstract class

Re: [PR] [FLINK-35457][checkpoint] Hotfix! close physical file under the protection of lock [flink]

2024-05-27 Thread via GitHub
Zakelly commented on code in PR #24846: URL: https://github.com/apache/flink/pull/24846#discussion_r1615993191 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -131,19 +131,22 @@ public abstract class

Re: [PR] [FLINK-35457][checkpoint] Hotfix! close physical file under the protection of lock [flink]

2024-05-27 Thread via GitHub
Zakelly commented on code in PR #24846: URL: https://github.com/apache/flink/pull/24846#discussion_r1615989878 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -131,19 +131,22 @@ public abstract class

Re: [PR] [FLINK-35457][checkpoint] Hotfix! close physical file under the protection of lock [flink]

2024-05-27 Thread via GitHub
fredia commented on code in PR #24846: URL: https://github.com/apache/flink/pull/24846#discussion_r1615819086 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -131,19 +131,22 @@ public abstract class

Re: [PR] [FLINK-35457][checkpoint] Hotfix! close physical file under the protection of lock [flink]

2024-05-27 Thread via GitHub
Zakelly commented on code in PR #24846: URL: https://github.com/apache/flink/pull/24846#discussion_r1615750150 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -131,19 +131,22 @@ public abstract class

Re: [PR] [FLINK-35457][checkpoint] Hotfix! close physical file under the protection of lock [flink]

2024-05-26 Thread via GitHub
flinkbot commented on PR #24846: URL: https://github.com/apache/flink/pull/24846#issuecomment-2132573107 ## CI report: * 411168066e0918d38167fc9e33861fc1945baa27 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35457][checkpoint] Hotfix! close physical file under the protection of lock [flink]

2024-05-26 Thread via GitHub
fredia opened a new pull request, #24846: URL: https://github.com/apache/flink/pull/24846 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on