Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-20 Thread via GitHub
gyfora merged PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
mateczagany commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1721835512 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/SnapshotObserver.java: ## @@ -219,64 +240,205 @@ private v

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-19 Thread via GitHub
mateczagany commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1721835078 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/SnapshotObserver.java: ## @@ -219,64 +240,205 @@ private v

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-18 Thread via GitHub
gyfora commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1721033240 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/SnapshotObserver.java: ## @@ -219,64 +240,205 @@ private void

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
gyfora commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1718038855 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -8,6 +8,24 @@ + +kubernetes.operator.checkpoi

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
mateczagany commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1718035018 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -8,6 +8,24 @@ + +kubernetes.operator.che

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-14 Thread via GitHub
gyfora commented on code in PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#discussion_r1716790329 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -8,6 +8,24 @@ + +kubernetes.operator.checkpoi

Re: [PR] [FLINK-35493][snapshot] Add historical cleanup for FlinkStateSnapshot CRs [flink-kubernetes-operator]

2024-08-12 Thread via GitHub
mateczagany commented on PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#issuecomment-2283318351 After talking with @gyfora I have made it so legacy savepoints will be cleaned up even if FlinkStateSnapshot is enabled for the job. This will use the number of compl