Re: [PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-07-04 Thread via GitHub
lincoln-lil merged PR #25020: URL: https://github.com/apache/flink/pull/25020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-07-04 Thread via GitHub
lincoln-lil merged PR #25019: URL: https://github.com/apache/flink/pull/25019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-07-03 Thread via GitHub
flinkbot commented on PR #25020: URL: https://github.com/apache/flink/pull/25020#issuecomment-2207884904 ## CI report: * edf481ede56ead71795b6e0c46f2672f9fe07571 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-07-03 Thread via GitHub
xuyangzhong opened a new pull request, #25020: URL: https://github.com/apache/flink/pull/25020 (cherry picked from commit 84165b23cfc756881d43cdab1b26c814d87e6227) ## What is the purpose of the change Cherry picked from commit 84165b23cfc756881d43cdab1b26c814d87e6227. See more

Re: [PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-07-03 Thread via GitHub
flinkbot commented on PR #25019: URL: https://github.com/apache/flink/pull/25019#issuecomment-2207880203 ## CI report: * d8eeb95cf13be488f53936db19d290cf0f579272 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-07-03 Thread via GitHub
xuyangzhong opened a new pull request, #25019: URL: https://github.com/apache/flink/pull/25019 (cherry picked from commit 84165b23cfc756881d43cdab1b26c814d87e6227) ## What is the purpose of the change Cherry picked from commit 84165b23cfc756881d43cdab1b26c814d87e6227. See more

Re: [PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-06-07 Thread via GitHub
lincoln-lil commented on code in PR #24890: URL: https://github.com/apache/flink/pull/24890#discussion_r1630964066 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/ExtractionUtils.java: ## @@ -844,7 +846,14 @@ private static class Parameter

Re: [PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-06-07 Thread via GitHub
lincoln-lil commented on code in PR #24890: URL: https://github.com/apache/flink/pull/24890#discussion_r1630981891 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java: ## @@ -1542,6 +1542,22 @@ void testUsingAddJ

Re: [PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-06-05 Thread via GitHub
flinkbot commented on PR #24890: URL: https://github.com/apache/flink/pull/24890#issuecomment-2149128429 ## CI report: * 8949372be348163ab172cdde89562de2f67f639f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35498][table] Fix unexpected argument name conflicts when extracting method parameter names from UDF [flink]

2024-06-05 Thread via GitHub
xuyangzhong opened a new pull request, #24890: URL: https://github.com/apache/flink/pull/24890 ## What is the purpose of the change Currently, we depend on asm to extract method parameter names. We custom a MethodVisitor to visit local variable tables in file `.class`, and then cut