leonardBang merged PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink
yuxiqian commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2271237005
Seems CI is failing since ValuesDatabase is trying to deserialize every
RecordData as STRINGs.
--
This is an automated message from the Apache Git Service.
To respond to the message,
leonardBang commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2271118899
>
It's expected as TIMESTAMP_LTZ type uses UTC0 timezone to get the string
expression
--
This is an automated message from the Apache Git Service.
To respond to the messag
yuxiqian commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2270865553
I've added a draft integrated test case for this at my branch
[here](https://github.com/yuxiqian/flink-cdc/tree/FLINK-35743-patch), but
noticed something strange. Run
`FlinkPipelineTr
yuxiqian commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2270607846
Seems `CURRENT_TIMESTAMP AS cur_ts` still doesn't work since Calcite deduces
its return type as `TIMESTAMP` instead of `TIMESTAMP_LTZ`, causing the
following Janino exception:
`
leonardBang commented on code in PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r1705038132
##
flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/parser/TransformParserTest.java:
##
@@ -292,6 +292,9 @@ public void testTranslateFilterToJaninoExp
aiwenmo commented on code in PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r1705026303
##
flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/parser/TransformParserTest.java:
##
@@ -292,6 +292,9 @@ public void testTranslateFilterToJaninoExpress
leonardBang commented on code in PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r1705002901
##
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/JaninoCompiler.java:
##
@@ -359,6 +407,15 @@ private static Java.Rvalue generateTypeConvert
yuxiqian commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2270319084
Sure, thanks for @aiwenmo's work so far, I'll create a patch for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
aiwenmo commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2270316674
@yuxiqian Hi. I'm busy with other things. Could you add an e2e test for the
temporal function?
For example: Mysql -> Transform -> Doris/Values
`projection: *,LOCALTIME as time1
leonardBang commented on code in PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r1704843782
##
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/functions/SystemFunctionUtils.java:
##
@@ -38,65 +41,62 @@
import java.util.regex.Matcher;
impor
leonardBang commented on code in PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r1704843120
##
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/JaninoCompiler.java:
##
@@ -359,6 +407,15 @@ private static Java.Rvalue generateTypeConvert
yuxiqian commented on code in PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r1704771418
##
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/JaninoCompiler.java:
##
@@ -300,7 +315,19 @@ private static Java.Rvalue generateOtherFunctionO
aiwenmo commented on code in PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r170478
##
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/JaninoCompiler.java:
##
@@ -359,6 +407,15 @@ private static Java.Rvalue generateTypeConvertMeth
aiwenmo commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2269264056
thx. I'm reviewing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
leonardBang commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2269086514
@aiwenmo @yuxiqian I append a commit to make sure our temporal function
semantics align with Flink SQL, please help review my commit
--
This is an automated message from the Apach
leonardBang commented on code in PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r1699834398
##
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/functions/SystemFunctionUtils.java:
##
@@ -64,22 +64,23 @@ public static TimestampData currentTime
yuxiqian commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2261867487
Seems running tests between 00:00 ~ 08:00 UTC (08:00 ~ 16:00 UTC+08:00) on
the first day of a month would trigger this problem.
--
This is an automated message from the Apache Git Se
aiwenmo commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2261821796
thx. I will add more test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
yuxiqian commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2261817511
It's August 1st again and similar CI failure is observed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
leonardBang commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2235283994
> Considering this fixes timezone functions' incorrect behavior, should this
be merged before 3.2 release? @leonardBang
+1 to merge this before 3.2 release
--
This is an au
yuxiqian commented on code in PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#discussion_r1663358098
##
flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/transform/TransformDataOperatorTest.java:
##
Review Comment:
I could still reproduce `
aiwenmo commented on PR #3449:
URL: https://github.com/apache/flink-cdc/pull/3449#issuecomment-2203201015
@yuxiqian PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
23 matches
Mail list logo
