lincoln-lil merged PR #25119:
URL: https://github.com/apache/flink/pull/25119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.a
lincoln-lil commented on PR #25119:
URL: https://github.com/apache/flink/pull/25119#issuecomment-2271454833
@xuyangzhong Could you rebase the master again(the e2e tests failure should
have been fixed).
--
This is an automated message from the Apache Git Service.
To respond to the
xuyangzhong commented on PR #25119:
URL: https://github.com/apache/flink/pull/25119#issuecomment-2271081624
@lincoln-lil Thanks for your review. I have updated it and rebased it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lincoln-lil commented on code in PR #25119:
URL: https://github.com/apache/flink/pull/25119#discussion_r1703254158
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/window/WindowRankOperatorBuilder.java:
##
@@ -116,11 +118,17 @@ publi
lincoln-lil commented on code in PR #25119:
URL: https://github.com/apache/flink/pull/25119#discussion_r1700398264
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/window/WindowRankOperatorBuilder.java:
##
@@ -152,6 +152,7 @@ public
flinkbot commented on PR #25119:
URL: https://github.com/apache/flink/pull/25119#issuecomment-2250260386
## CI report:
* f529368b2ff98c7a50d5e790c9b9ca879ca200a8 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
xuyangzhong opened a new pull request, #25119:
URL: https://github.com/apache/flink/pull/25119
## What is the purpose of the change
This pr tries to ignore the advancement of the window processor caused by
watermark in proctime window agg.
## Brief change log
- *Ignore
