Re: [PR] [FLINK-36318] Fix deserializing from 1.18 savepoint with RAW types [flink]

2024-09-20 Thread via GitHub
dawidwys closed pull request #25357: [FLINK-36318] Fix deserializing from 1.18 savepoint with RAW types URL: https://github.com/apache/flink/pull/25357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [FLINK-36318] Fix deserializing from 1.18 savepoint with RAW types [flink]

2024-09-20 Thread via GitHub
dawidwys commented on code in PR #25357: URL: https://github.com/apache/flink/pull/25357#discussion_r1768343224 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/RowDataSerializer.java: ## @@ -314,7 +314,8 @@ public void readSnapshot(int r

Re: [PR] [FLINK-36318] Fix deserializing from 1.18 savepoint with RAW types [flink]

2024-09-20 Thread via GitHub
twalthr commented on code in PR #25357: URL: https://github.com/apache/flink/pull/25357#discussion_r1768266516 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -144,7 +150,42 @@ private Stream c

Re: [PR] [FLINK-36318] Fix deserializing from 1.18 savepoint with RAW types [flink]

2024-09-19 Thread via GitHub
snuyanzin commented on PR #25357: URL: https://github.com/apache/flink/pull/25357#issuecomment-2360141196 seems need to apply spotless -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-36318] Fix deserializing from 1.18 savepoint with RAW types [flink]

2024-09-18 Thread via GitHub
flinkbot commented on PR #25357: URL: https://github.com/apache/flink/pull/25357#issuecomment-2358957518 ## CI report: * 37429ee80d2ef9314b807144bdc6c536848cef80 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36318] Fix deserializing from 1.18 savepoint with RAW types [flink]

2024-09-18 Thread via GitHub
dawidwys commented on code in PR #25357: URL: https://github.com/apache/flink/pull/25357#discussion_r1765312051 ## flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java: ## @@ -146,144 +144,93 @@ protected Class resolveProxyClass(String[] interfaces) }

[PR] [FLINK-36318] Fix deserializing from 1.18 savepoint with RAW types [flink]

2024-09-18 Thread via GitHub
dawidwys opened a new pull request, #25357: URL: https://github.com/apache/flink/pull/25357 ## What is the purpose of the change The commit fixes restoring from savepoints which were created for SQL queries which used functions such as LAG/LEAD/ARRAY_AGG which use a RAW type