Re: [PR] [FLINK-36338] Properly handle KeyContext when using AsyncKeyedStateBackendAdaptor [flink]

2024-09-23 Thread via GitHub
Zakelly merged PR #25367: URL: https://github.com/apache/flink/pull/25367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-36338] Properly handle KeyContext when using AsyncKeyedStateBackendAdaptor [flink]

2024-09-22 Thread via GitHub
Zakelly commented on code in PR #25367: URL: https://github.com/apache/flink/pull/25367#discussion_r1770772924 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java: ## @@ -250,6 +250,13 @@ public void setCurrentKey(K newKey) {

Re: [PR] [FLINK-36338] Properly handle KeyContext when using AsyncKeyedStateBackendAdaptor [flink]

2024-09-22 Thread via GitHub
Zakelly commented on code in PR #25367: URL: https://github.com/apache/flink/pull/25367#discussion_r1770746753 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -189,6 +194,9 @@ public RecordContext buildContext(Object r

Re: [PR] [FLINK-36338] Properly handle KeyContext when using AsyncKeyedStateBackendAdaptor [flink]

2024-09-22 Thread via GitHub
Zakelly commented on code in PR #25367: URL: https://github.com/apache/flink/pull/25367#discussion_r1770742198 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -189,6 +194,9 @@ public RecordContext buildContext(Object r

Re: [PR] [FLINK-36338] Properly handle KeyContext when using AsyncKeyedStateBackendAdaptor [flink]

2024-09-22 Thread via GitHub
fredia commented on code in PR #25367: URL: https://github.com/apache/flink/pull/25367#discussion_r1770726474 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java: ## @@ -189,6 +194,9 @@ public RecordContext buildContext(Object re

Re: [PR] [FLINK-36338] Properly handle KeyContext when using AsyncKeyedStateBackendAdaptor [flink]

2024-09-20 Thread via GitHub
flinkbot commented on PR #25367: URL: https://github.com/apache/flink/pull/25367#issuecomment-2363459765 ## CI report: * 90aa9496b9954906ec1cce3c37d67a1ed4f682ea UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36338] Properly handle KeyContext when using AsyncKeyedStateBackendAdaptor [flink]

2024-09-20 Thread via GitHub
Zakelly opened a new pull request, #25367: URL: https://github.com/apache/flink/pull/25367 ## What is the purpose of the change After [FLINK-36117](https://issues.apache.org/jira/browse/FLINK-36117), we port old state backends implementation to new api using AsyncKeyedStateBackendAda