Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-15 Thread via GitHub
becketqin merged PR #23865: URL: https://github.com/apache/flink/pull/23865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-12 Thread via GitHub
pvary commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1853315289 @becketqin: Thanks for the example changes! They really help to make sense of the previous table. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-12 Thread via GitHub
becketqin commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1853288782 @pvary Sorry for the late response. I read the section a few times and found that the compatibility guarantee statement itself is actually concise and accurate. However, the the

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-05 Thread via GitHub
pvary commented on code in PR #23865: URL: https://github.com/apache/flink/pull/23865#discussion_r1415756044 ## docs/content/docs/ops/upgrading.md: ## @@ -60,6 +60,32 @@ Code written against a `PublicEvolving` API in 1.15.2 will continue to run in 1. That same code would have

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-05 Thread via GitHub
pvary commented on code in PR #23865: URL: https://github.com/apache/flink/pull/23865#discussion_r1415756044 ## docs/content/docs/ops/upgrading.md: ## @@ -60,6 +60,32 @@ Code written against a `PublicEvolving` API in 1.15.2 will continue to run in 1. That same code would have

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-05 Thread via GitHub
pvary commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1840787769 I would suggest to change the [previous](https://nightlies.apache.org/flink/flink-docs-master/docs/ops/upgrading/#api-compatibility-guarantees) paragraph, like the following (remove the

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-05 Thread via GitHub
gaborgsomogyi commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1840452321 Thanks for the explanation! > In terms of the source / binary compatibility, the main reason we do not provide binary compatibility in minor releases for any API stability

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-04 Thread via GitHub
becketqin commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1839717057 @pvary @mbalassi @gaborgsomogyi @JingGe Thanks a lot for the reviews. From what I understand, FLIP-321 does not change the API stability guarantee, it only specifies a migration

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-04 Thread via GitHub
gaborgsomogyi commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1838941714 I've had an in-depth look on the compatibility guarantee matrix together with the deprecation policy and here are my findings: * The doc basically looks good from content

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-04 Thread via GitHub
mbalassi commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1838566349 Thanks for the quick turnaround, @becketqin. I agree with @pvary that we should adjust the [table just

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-04 Thread via GitHub
pvary commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1838229419 @becketqin: We might want to edit the previous section too. I think it is a bit misleading when we state there that a `PublicEvolving` API is not source/binary compatible across

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-03 Thread via GitHub
JingGe commented on code in PR #23865: URL: https://github.com/apache/flink/pull/23865#discussion_r1413472466 ## docs/content/docs/ops/upgrading.md: ## @@ -60,6 +60,32 @@ Code written against a `PublicEvolving` API in 1.15.2 will continue to run in 1. That same code would

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-03 Thread via GitHub
JingGe commented on code in PR #23865: URL: https://github.com/apache/flink/pull/23865#discussion_r1413472466 ## docs/content/docs/ops/upgrading.md: ## @@ -60,6 +60,32 @@ Code written against a `PublicEvolving` API in 1.15.2 will continue to run in 1. That same code would

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-03 Thread via GitHub
flinkbot commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1837911822 ## CI report: * aa4d7a5834e436ea8374efd610bb1e257a9ed5af UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-03 Thread via GitHub
becketqin commented on PR #23865: URL: https://github.com/apache/flink/pull/23865#issuecomment-1837910118 @mbalassi Do you have time to take a look at the doc update? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] [FLIP-321] Update the docs to add migration periods for deprecated APIs. [flink]

2023-12-03 Thread via GitHub
becketqin opened a new pull request, #23865: URL: https://github.com/apache/flink/pull/23865 ## What is the purpose of the change This PR update the ops doc to add the migration periods for deprecated APIs, which are specified in