Re: [PR] [hotfix][runtime] Remove unneeded requestTaskManagerFileUploadByName [flink]

2024-02-29 Thread via GitHub
1996fanrui merged PR #24386: URL: https://github.com/apache/flink/pull/24386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [hotfix][runtime] Remove unneeded requestTaskManagerFileUploadByName [flink]

2024-02-29 Thread via GitHub
1996fanrui commented on PR #24386: URL: https://github.com/apache/flink/pull/24386#issuecomment-1972683847 Thanks @yuchen-ecnu for the review, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [hotfix][runtime] Remove unneeded requestTaskManagerFileUploadByName [flink]

2024-02-27 Thread via GitHub
yuchen-ecnu commented on PR #24386: URL: https://github.com/apache/flink/pull/24386#issuecomment-1968318607 Thanks for your quick fix. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [hotfix][runtime] Remove unneeded requestTaskManagerFileUploadByName [flink]

2024-02-27 Thread via GitHub
1996fanrui commented on code in PR #24386: URL: https://github.com/apache/flink/pull/24386#discussion_r1503994275 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/utils/TestingResourceManagerGateway.java: ## @@ -458,19 +458,6 @@ public CompletableFuture r

Re: [PR] [hotfix][runtime] Remove unneeded requestTaskManagerFileUploadByName [flink]

2024-02-27 Thread via GitHub
yuchen-ecnu commented on code in PR #24386: URL: https://github.com/apache/flink/pull/24386#discussion_r1503903205 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/utils/TestingResourceManagerGateway.java: ## @@ -458,19 +458,6 @@ public CompletableFuture

Re: [PR] [hotfix][runtime] Remove unneeded requestTaskManagerFileUploadByName [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24386: URL: https://github.com/apache/flink/pull/24386#issuecomment-1965794105 ## CI report: * 8e7d875175306a508fc856990b463a2fdac23960 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`