Re: [PR] [hotfix][sqlgateway] Do not introduce new method in SqlGatewayEndpointFactory#Context [flink]

2024-05-26 Thread via GitHub
reswqa merged PR #24838: URL: https://github.com/apache/flink/pull/24838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][sqlgateway] Do not introduce new method in SqlGatewayEndpointFactory#Context [flink]

2024-05-26 Thread via GitHub
reswqa commented on PR #24838: URL: https://github.com/apache/flink/pull/24838#issuecomment-2132499806 Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [hotfix][sqlgateway] Do not introduce new method in SqlGatewayEndpointFactory#Context [flink]

2024-05-24 Thread via GitHub
flinkbot commented on PR #24838: URL: https://github.com/apache/flink/pull/24838#issuecomment-2128628755 ## CI report: * c2460846f9f6883f337f85ff3e74138601c2a678 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][sqlgateway] Do not introduce new method in SqlGatewayEndpointFactory#Context [flink]

2024-05-24 Thread via GitHub
reswqa opened a new pull request, #24838: URL: https://github.com/apache/flink/pull/24838 ## What is the purpose of the change *Do not introduce new method in SqlGatewayEndpointFactory#Context as we have `toMap` method in `ReadableConfig` now.,* ## Verifying this change

Re: [PR] [hotfix][sqlgateway] Do not introduce new method in SqlGatewayEndpointFactory#Context [flink]

2024-05-23 Thread via GitHub
flinkbot commented on PR #24831: URL: https://github.com/apache/flink/pull/24831#issuecomment-2126456457 ## CI report: * ad9db034f315f7aff70638c7c2cd6915db9597bd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`