Re: [PR] [hotfix][table] refactoring to template method to separate concerns [flink]

2024-06-06 Thread via GitHub
JingGe merged PR #23857: URL: https://github.com/apache/flink/pull/23857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][table] refactoring to template method to separate concerns [flink]

2023-12-04 Thread via GitHub
JingGe commented on PR #23857: URL: https://github.com/apache/flink/pull/23857#issuecomment-1838480627 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [hotfix][table] refactoring to template method to separate concerns [flink]

2023-12-03 Thread via GitHub
fsk119 commented on code in PR #23857: URL: https://github.com/apache/flink/pull/23857#discussion_r1413440533 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/print/TableauStyle.java: ## @@ -115,14 +115,26 @@ public final class TableauStyle

Re: [PR] [hotfix][table] refactoring to template method to separate concerns [flink]

2023-12-02 Thread via GitHub
flinkbot commented on PR #23857: URL: https://github.com/apache/flink/pull/23857#issuecomment-1837186832 ## CI report: * b7f62e249f5ad4280b0a994bf87ef64323d2dee3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][table] refactoring to template method to separate concerns [flink]

2023-12-02 Thread via GitHub
JingGe opened a new pull request, #23857: URL: https://github.com/apache/flink/pull/23857 ## What is the purpose of the change refactoring to template method to separate concerns ## Verifying this change This change is already covered by existing tests, such as