Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]

2023-12-14 Thread via GitHub
TestBoost commented on PR #23910: URL: https://github.com/apache/flink/pull/23910#issuecomment-1856543512 Hi, So to clarify, would the preferred change be to start a cluster per-test-class and to share between test methods? Looking at the test class, perhaps this could be accomplishe

Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]

2023-12-14 Thread via GitHub
reswqa commented on PR #23910: URL: https://github.com/apache/flink/pull/23910#issuecomment-1857249121 To be honest, I prefer to leave it as it is. Since I don't see much benefit, this `1s` speed up doesn't necessarily show up in the CI environment, but it does increase the instability of t