[PR] [hotfix] Extract common preparing directory code into one function [flink-benchmarks]

2024-01-06 Thread via GitHub
Zakelly opened a new pull request, #84: URL: https://github.com/apache/flink-benchmarks/pull/84 In https://github.com/apache/flink-benchmarks/pull/79#discussion_r1333857024, we left some duplicated code in preparing the directory for state benchmark. This PR do some code extraction to fix

Re: [PR] [hotfix] Extract common preparing directory code into one function [flink-benchmarks]

2024-01-06 Thread via GitHub
Zakelly commented on PR #84: URL: https://github.com/apache/flink-benchmarks/pull/84#issuecomment-1879926769 @masteryhx Would you please take a look? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [hotfix] Extract common preparing directory code into one function [flink-benchmarks]

2024-01-08 Thread via GitHub
masteryhx commented on PR #84: URL: https://github.com/apache/flink-benchmarks/pull/84#issuecomment-1882394452 merged 8b0b1c62 into master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [hotfix] Extract common preparing directory code into one function [flink-benchmarks]

2024-01-08 Thread via GitHub
masteryhx closed pull request #84: [hotfix] Extract common preparing directory code into one function URL: https://github.com/apache/flink-benchmarks/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t