liuml07 commented on code in PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613711076
##
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java:
##
@@ -0,0 +1,69 @@
+pa
liuml07 commented on code in PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613694681
##
flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java:
##
@@ -100,16 +1
reta commented on code in PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613490458
##
flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java:
##
@@ -100,16 +111,
reta commented on code in PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613488632
##
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java:
##
@@ -0,0 +1,69 @@
+packa
reta commented on PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#issuecomment-2128158649
> @reta and @snuyanzin Could you take a look?
Sure, I will do that within next few days, thank you @liuml07 !
--
This is an automated message from the Apache Git
reta commented on PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#issuecomment-2128158218
> Also I'm not sure how to fix the pre-check failure:
I think slight change to `[FLINK-35424] Elasticsearch connector 8 supports
SSL context` would make it pass
liuml07 commented on PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#issuecomment-2128004309
@reta and @snuyanzin Could you take a look?
Also I'm not sure how to fix the pre-check failure:
```
Title Validator — Wrong Commit title:
[FLINK-35424][co
liuml07 commented on PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#issuecomment-2127907729
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
