ukby1234 closed pull request #24029: [FLINK-33759] [flink-parquet] Add support
for nested array with row type
URL: https://github.com/apache/flink/pull/24029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
JingGe merged PR #24795:
URL: https://github.com/apache/flink/pull/24795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2133329919
@JingGe CI Passed, I dindn't realize the bot just editted the same comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2130263489
> @ViktorCosenza did you rebase?
Yes, i did an interactive rebase and then force-pushed the squashed commits
--
This is an automated message from the Apache Git Service.
To
JingGe commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2130068966
@ViktorCosenza did you rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
JingGe commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2130067792
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2129462557
@JingGe Are you able to trigger the CI manually? I think I't wasnt triggered
after the squash because no changes were detected.
--
This is an automated message from the Apache Git
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2126981554
> Thanks for the hint! Would you mind if I picked up some of your code to
paimon?
Sure, go ahead!
--
This is an automated message from the Apache Git Service.
To respond to
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2126972794
> @ViktorCosenza would you please squash your commits and rebase it? Once it
passed the CI, I will merge the PR. Thanks!
Done! But I wasn't able to trigger the CI
--
This i
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2126966568
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2126965517
@flinkbot run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
JingGe commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2126441145
> > > Do you have any hints about the background info?
> >
> >
> > Not really, I found out this issue because we were trying to save
Parquet files to S3 and the writer would fail
JingGe commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2126427307
@ViktorCosenza would you please squash your commits and rebase it? Once it
passed the CI, I will merge the PR. Thanks!
--
This is an automated message from the Apache Git Service.
To res
JingGe commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2126415976
I talked with @JingsongLi offline. It seems that at that time there was no
such requirement and therefore skipped those implementation.
--
This is an automated message from the Apache Gi
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2125705836
I see, Ive got the impression that they were forgotten, not purposely left
out because no tests covered writing nested structures ( if there were, the
tests would fail and the m
JingGe commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2125686671
It looks like those methods were skipped on purpose in #17542 and
https://github.com/apache/flink/pull/17542#issuecomment-1954552466
--
This is an automated message from the Apache Git S
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2125670540
> > Do you have any hints about the background info?
>
> Not really, I found out this issue because we were trying to save Parquet
files to S3 and the writer would fail due to
JingGe commented on code in PR #24795:
URL: https://github.com/apache/flink/pull/24795#discussion_r1610586619
##
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java:
##
@@ -381,9 +381,16 @@ private MapWriter(LogicalType keyTyp
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2125663861
> Do you have any hints about the background info?
Not really, I found out this issue because we were trying to save Parquet
files to S3 and the writer would fail due to empty
JingGe commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2125655594
Thanks @ViktorCosenza for taking care of it. The PR looks overall good. Not
sure why those `write(ArrayData arrayData, int ordinal)` methods didn't get
implemented. It should be trivial to
ViktorCosenza commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2124999154
> Thanks! The PR looks good to me. Hi @JingsongLi, please also take a look.
I think we can port this to fix
[apache/paimon#1730](https://github.com/apache/paimon/issues/1730)
LoveHeat commented on PR #23881:
URL: https://github.com/apache/flink/pull/23881#issuecomment-2114470949
> Hi @LoveHeat, can you cherry-pick the change in #24029 from @ukby1234 and
merge the two PRs?
sorry，just saw this～
--
This is an automated message from the Apache Git Service.
LoveHeat opened a new pull request, #23881:
URL: https://github.com/apache/flink/pull/23881
## What is the purpose of the change
see: [FLINK-33759](https://issues.apache.org/jira/browse/FLINK-33759)
## Brief change log
*(for example:)*
- *The TaskInfo is
LoveHeat commented on PR #23881:
URL: https://github.com/apache/flink/pull/23881#issuecomment-2114456784
> Hi @LoveHeat, can you cherry-pick the change in #24029 from @ukby1234 and
merge the two PRs?
--
This is an automated message from the Apache Git Service.
To respond to the me
LoveHeat closed pull request #23881: [FLINK-33759] flink parquet writer support
write nested array or map type
URL: https://github.com/apache/flink/pull/23881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
flinkbot commented on PR #24795:
URL: https://github.com/apache/flink/pull/24795#issuecomment-2113596687
## CI report:
* c3b588c4a44d135ccebe6acafa75e3b1a9aa4895 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
ViktorCosenza commented on PR #23881:
URL: https://github.com/apache/flink/pull/23881#issuecomment-2113594484
> Hi @LoveHeat, can you cherry-pick the change in #24029 from @ukby1234 and
merge the two PRs?
@xccui, i've created a PR cherry picking both commits:
https://github.com/apach
ViktorCosenza opened a new pull request, #24795:
URL: https://github.com/apache/flink/pull/24795
## What is the purpose of the change
This Pull request adds commits from
https://github.com/apache/flink/pull/24029 and
https://github.com/apache/flink/pull/23881 to fully resolve iss
xccui commented on PR #23881:
URL: https://github.com/apache/flink/pull/23881#issuecomment-2104688811
Hi @LoveHeat, can you cherry-pick the change in
https://github.com/apache/flink/pull/24029 from @ukby1234 and merge the two PRs?
--
This is an automated message from the Apache Git Servic
ukby1234 commented on PR #24029:
URL: https://github.com/apache/flink/pull/24029#issuecomment-2101240856
Yes I would love to have review/test on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ViktorCosenza commented on PR #24029:
URL: https://github.com/apache/flink/pull/24029#issuecomment-2101016302
Hi, we're having this exact issue in our team and found this PR fixing it,
is there a expected timeframe for this to be merged?
If any help is needed to test/review this I'm happy
ViktorCosenza commented on PR #23881:
URL: https://github.com/apache/flink/pull/23881#issuecomment-2100970888
Hi, I'm having a issue directly related to the empty "write" methods when
trying to write a Parquet with an array of row.
I've noticed you fixed the issue for the Map and Arra
ukby1234 commented on PR #24029:
URL: https://github.com/apache/flink/pull/24029#issuecomment-1992944538
@MartijnVisser can you help review this PR? and possibly
https://github.com/apache/flink/pull/23881 as well?
--
This is an automated message from the Apache Git Service.
To respond to
flinkbot commented on PR #24029:
URL: https://github.com/apache/flink/pull/24029#issuecomment-1878195014
## CI report:
* 5e614717b3d19a566939cd2dca8ae414c37f765f UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
ukby1234 commented on PR #24029:
URL: https://github.com/apache/flink/pull/24029#issuecomment-1878191452
This adds the missing case for https://github.com/apache/flink/pull/23881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ukby1234 opened a new pull request, #24029:
URL: https://github.com/apache/flink/pull/24029
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring them o
flinkbot commented on PR #23881:
URL: https://github.com/apache/flink/pull/23881#issuecomment-1842150254
## CI report:
* beeb17b4d54d2c2ed0ea61df6e07892bc792e2e0 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
LoveHeat opened a new pull request, #23881:
URL: https://github.com/apache/flink/pull/23881
## What is the purpose of the change
see: [FLINK-33759](https://issues.apache.org/jira/browse/FLINK-33759)
## Brief change log
*(for example:)*
- *The TaskInfo is
38 matches
Mail list logo
