[
https://issues.apache.org/jira/browse/FLINK-27555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534423#comment-17534423
]
Zhu Zhu edited comment on FLINK-27555 at 5/10/22 3:48 PM:
----------------------------------------------------------
I think #2 is the correct way.
Maybe we can modify the
[save_jmh_result.py|https://github.com/apache/flink-benchmarks/blob/master/save_jmh_result.py]
to correctly set the 'units' and the 'lessisbetter' fields of benchmark
results. The 'units' is already contained in the jmh result and the
'lessisbetter' can be derived from the mode(false if it is 'thrpt' mode,
otherwise true). An example of the jmh result format can be found at
https://i.stack.imgur.com/vB3fV.png.
This can fix the web UI as well as the REST result, and then the
[regression_report.py|https://github.com/apache/flink-benchmarks/blob/master/regression_report.py]
will be able to identify which benchmarks are "less is better" and treat them
differently.
was (Author: zhuzh):
I think #2 is the correct way.
Maybe we can modify the
[save_jmh_result.py|https://github.com/apache/flink-benchmarks/blob/master/save_jmh_result.py]
to correctly set the 'units' and the 'lessisbetter' fields of benchmark
results. The 'units' is already contained in the jmh result and the
'lessisbetter' can be derived from the mode(false if it is 'thrpt' mode,
otherwise true).
This can fix the web UI as well as the REST result, and then the
[regression_report.py|https://github.com/apache/flink-benchmarks/blob/master/regression_report.py]
will be able to identify which benchmarks are "less is better" and treat them
differently.
> Performance regression in schedulingDownstreamTasks on 02.05.2022
> -----------------------------------------------------------------
>
> Key: FLINK-27555
> URL: https://issues.apache.org/jira/browse/FLINK-27555
> Project: Flink
> Issue Type: Bug
> Components: Benchmarks
> Affects Versions: 1.16.0
> Reporter: Roman Khachatryan
> Priority: Major
> Attachments: Screenshot_2022-05-09_10-33-11.png
>
>
> http://codespeed.dak8s.net:8000/timeline/#/?exe=5&ben=schedulingDownstreamTasks.BATCH&extr=on&quarts=on&equid=off&env=2&revs=200
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
