[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-06-05 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856767#comment-16856767 ] vinoyang commented on FLINK-12683: -- [~till.rohrmann] thanks, I will reopen this PR and ping you to

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-06-05 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856752#comment-16856752 ] Till Rohrmann commented on FLINK-12683: --- Ok I see your point [~yanghua]. I'm just wondering

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-06-04 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855562#comment-16855562 ] vinoyang commented on FLINK-12683: -- Hi [~till.rohrmann] I think a good log message should describe a

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-06-04 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855524#comment-16855524 ] Till Rohrmann commented on FLINK-12683: --- I agree with [~klion26] that the logs should already

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852668#comment-16852668 ] vinoyang commented on FLINK-12683: -- I think for logging, the good practice is that it should provide

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852658#comment-16852658 ] Congxian Qiu(klion26) commented on FLINK-12683: --- In my opinion, the jm log of current

[jira] [Commented] (FLINK-12683) Provide task manager's location information for checkpoint coordinator specific log messages

2019-05-30 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852600#comment-16852600 ] vinoyang commented on FLINK-12683: -- Hi [~klion26] Here is my plan: Changing these two methods'