[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949876#comment-16949876
]
Jiayi Liao commented on FLINK-14296:
[~dwysakowicz] [~jark] Thanks for pointing this out. The PR can
[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949350#comment-16949350
]
Jiayi Liao commented on FLINK-14296:
[~jark] Sure. I'll update the PR very soon.
> SqlNodes in the
[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947578#comment-16947578
]
Jark Wu commented on FLINK-14296:
-
Hi [~wind_ljy], could you update the PR according to the discussion
[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947521#comment-16947521
]
Dawid Wysakowicz commented on FLINK-14296:
--
Sure, I'm fine with that approach. I just wanted to
[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947516#comment-16947516
]
Jark Wu commented on FLINK-14296:
-
Thanks [~dwysakowicz], I think we should check not null for
[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947486#comment-16947486
]
Dawid Wysakowicz commented on FLINK-14296:
--
Sorry I made you wait for a response.
I would
[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946423#comment-16946423
]
Jark Wu commented on FLINK-14296:
-
Hi [~wind_ljy], thanks for the PR, but before submitting the PR, I
[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945233#comment-16945233
]
Jiayi Liao commented on FLINK-14296:
[~jark]
> SqlNodes in the parser module should use an Optional
[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945224#comment-16945224
]
Jark Wu commented on FLINK-14296:
-
I agree with [~wind_ljy]. {{SqlNodeList}} is a List of SqlNode. We
[
https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941677#comment-16941677
]
Jiayi Liao commented on FLINK-14296:
[~dawidwys]
Actually the partitionKeyList / columnList /
10 matches
Mail list logo