[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Hao Dang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952786#comment-16952786 ] Hao Dang commented on FLINK-14398: -- Sounds good, [~twalthr].  I should be able to put up a PR in the

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952771#comment-16952771 ] Timo Walther commented on FLINK-14398: -- I assigned it to you [~haodang]. It would be great to not

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Hao Dang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952747#comment-16952747 ] Hao Dang commented on FLINK-14398: -- Thanks for the explanation! And yea, feel free to assign it to me

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952684#comment-16952684 ] Timo Walther commented on FLINK-14398: -- [~jark] I agree, I think for the Blink planner we need a

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Hao Dang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952676#comment-16952676 ] Hao Dang commented on FLINK-14398: -- Totally agree on a proper design doc for scoping and planning as

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952632#comment-16952632 ] Jark Wu commented on FLINK-14398: - For fixing, I think it's fine to fix it first in old planner in a

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952629#comment-16952629 ] Jark Wu commented on FLINK-14398: - Thanks. I agree with splitting can solve this problem. But from the

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Hao Dang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952611#comment-16952611 ] Hao Dang commented on FLINK-14398: -- Indeed, [~twalthr] and [~jark]. Thanks for the quick response. The

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952607#comment-16952607 ] Timo Walther commented on FLINK-14398: -- [~jark] the code splitting is limited at the moment. It

[jira] [Commented] (FLINK-14398) Codegen produced larger-than-64kb method

2019-10-16 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952596#comment-16952596 ] Jark Wu commented on FLINK-14398: - Hi [~haodang], thanks for reporting this. I think you are using the