[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

2020-01-13 Thread Andrew.D.lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014810#comment-17014810 ] Andrew.D.lin commented on FLINK-15307: -- [~zhuzh] sorry, I missed it, Let me modify

[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

2020-01-13 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014799#comment-17014799 ] Zhu Zhu commented on FLINK-15307: - The legacy failover strategies will be removed in 1.1

[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

2020-01-13 Thread Andrew.D.lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014771#comment-17014771 ] Andrew.D.lin commented on FLINK-15307: -- Hi [~zhuzh]  I open the PR: [https://githu

[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

2019-12-19 Thread andrew.D.lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000673#comment-17000673 ] andrew.D.lin commented on FLINK-15307: -- Hi [~zhuzh], [~tison]  OK, I am willing to

[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

2019-12-19 Thread andrew.D.lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000666#comment-17000666 ] andrew.D.lin commented on FLINK-15307: -- [~zhuzh]  [~tison]   > Subclasses of Failo

[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

2019-12-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000664#comment-17000664 ] Zhu Zhu commented on FLINK-15307: - Sure, I can ping him here after the pre-requisites ar

[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

2019-12-19 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000662#comment-17000662 ] Zili Chen commented on FLINK-15307: --- Thanks for your reply [~zhuzh]. Could you guide [

[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

2019-12-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000660#comment-17000660 ] Zhu Zhu commented on FLINK-15307: - Agreed that we can change the class name to avoid con

[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

2019-12-19 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000653#comment-17000653 ] Zili Chen commented on FLINK-15307: --- cc [~zhuzh] what do you think of this? > Subclas