[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126695#comment-17126695 ] Jark Wu commented on FLINK-16497: - Btw, I will only apply the changes to the new JDBC connector, so it

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126694#comment-17126694 ] Jark Wu commented on FLINK-16497: - Thank you all for the disucssion. I will create a pull request for

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-05 Thread sunjincheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126642#comment-17126642 ] sunjincheng commented on FLINK-16497: - Thank you for active discussion！My original intention

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126471#comment-17126471 ] Jark Wu commented on FLINK-16497: - It seems that more people prefer to have a trade off between

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-05 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126446#comment-17126446 ] lincoln lee commented on FLINK-16497: - +1 to default flush size (100) and flush interval(1s) I

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126395#comment-17126395 ] Benchao Li commented on FLINK-16497: +1 to Danny's proposal. > Improve default flush strategy for

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-04 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126378#comment-17126378 ] Jingsong Lee commented on FLINK-16497: -- +1 to default flush size (100) and flush interval(1s).  I

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-04 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126373#comment-17126373 ] Danny Chen commented on FLINK-16497: I think as a popular streaming engine, ensure good throughput

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123622#comment-17123622 ] Leonard Xu commented on FLINK-16497: Thanks [~sunjincheng121] and [~libenchao] 's detailed comments.

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-01 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120969#comment-17120969 ] Benchao Li commented on FLINK-16497: Hi [~sunjincheng121] , thanks for your detailed explanation,

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-06-01 Thread sunjincheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120927#comment-17120927 ] sunjincheng commented on FLINK-16497: - Hi [~libenchao] , Thanks for your reply! I think is is

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120708#comment-17120708 ] Jark Wu commented on FLINK-16497: - [~lzljs3620320], what do you think about this? > Improve default

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-05-31 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120696#comment-17120696 ] Benchao Li commented on FLINK-16497: [~sunjincheng121] Thanks for addressing this issue, I like the

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-05-31 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120549#comment-17120549 ] Leonard Xu commented on FLINK-16497: +1 for this. And I‘d like to open PR for master and 1.11.0

[jira] [Commented] (FLINK-16497) Improve default flush strategy for JDBC sink to make it work out-of-box

2020-05-31 Thread sunjincheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120532#comment-17120532 ] sunjincheng commented on FLINK-16497: - +1 for thi,s as I mentioned in FLINK-18041, and I prefer 1