[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-12-30 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256401#comment-17256401 ] Till Rohrmann commented on FLINK-16998: --- Quick question [~twalthr]: Did this change break

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-06-03 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124885#comment-17124885 ] Timo Walther commented on FLINK-16998: -- Updating the `Row.toString` method will be postponed to

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-20 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112566#comment-17112566 ] Timo Walther commented on FLINK-16998: -- Backwards compatibility added. Fixed in 1.11.0:

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-18 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110549#comment-17110549 ] Timo Walther commented on FLINK-16998: -- Changeflag has been added. Backwards compatibility will

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-12 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105469#comment-17105469 ] Timo Walther commented on FLINK-16998: -- In order to unblock FLINK-14807, I will open a PR with the

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-06 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100521#comment-17100521 ] Timo Walther commented on FLINK-16998: -- Thanks everyone for your feedback. So we go with no

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-05 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100403#comment-17100403 ] Jingsong Lee commented on FLINK-16998: -- +1 to keep nested flag. When introducing data structure,

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-05 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100373#comment-17100373 ] Kurt Young commented on FLINK-16998: Keep internal row's header makes sense, especially when we want

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-05 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099947#comment-17099947 ] Dawid Wysakowicz commented on FLINK-16998: -- Your discussion in the JIRA issue exactly reflects

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-05 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099753#comment-17099753 ] Timo Walther commented on FLINK-16998: -- Unless we adjust our data structure converters and remove

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099750#comment-17099750 ] Jark Wu commented on FLINK-16998: - That's right... Then I think it's reasonable to make the RowKind

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-05 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099749#comment-17099749 ] Timo Walther commented on FLINK-16998: -- Honestly, I would also prefer {{+I(12, 12, (Hello,

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099739#comment-17099739 ] Jark Wu commented on FLINK-16998: - I'm fine with this. Another choice is to make the {{RowKind}}

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-05 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099696#comment-17099696 ] Timo Walther commented on FLINK-16998: -- [~jark] [~dwysakowicz] before I do the big refactoring of

[jira] [Commented] (FLINK-16998) Add a changeflag to Row type

2020-05-05 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099675#comment-17099675 ] Tzu-Li (Gordon) Tai commented on FLINK-16998: - Blocked by FLINK-17520. > Add a changeflag