[jira] [Commented] (FLINK-17820) Memory threshold is ignored for channel state

2020-05-26 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116496#comment-17116496 ] Roman Khachatryan commented on FLINK-17820: --- I've created a PR: [https://githu

[jira] [Commented] (FLINK-17820) Memory threshold is ignored for channel state

2020-05-25 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116469#comment-17116469 ] Roman Khachatryan commented on FLINK-17820: --- I agree about (2) (adjust {{FsChe

[jira] [Commented] (FLINK-17820) Memory threshold is ignored for channel state

2020-05-25 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116150#comment-17116150 ] Stephan Ewen commented on FLINK-17820: -- It is true, the assumption that {{DataOutpu

[jira] [Commented] (FLINK-17820) Memory threshold is ignored for channel state

2020-05-25 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115851#comment-17115851 ] Roman Khachatryan commented on FLINK-17820: --- {quote}What do you think about ad

[jira] [Commented] (FLINK-17820) Memory threshold is ignored for channel state

2020-05-23 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114859#comment-17114859 ] Stephan Ewen commented on FLINK-17820: -- Regarding changing the behavior of {{FsChec

[jira] [Commented] (FLINK-17820) Memory threshold is ignored for channel state

2020-05-23 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114849#comment-17114849 ] Stephan Ewen commented on FLINK-17820: -- I see. You cannot rely on {{close()}} here

[jira] [Commented] (FLINK-17820) Memory threshold is ignored for channel state

2020-05-20 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112651#comment-17112651 ] Roman Khachatryan commented on FLINK-17820: --- The data to FsCheckpointStateOutp

[jira] [Commented] (FLINK-17820) Memory threshold is ignored for channel state

2020-05-20 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112643#comment-17112643 ] Stephan Ewen commented on FLINK-17820: -- I would simply avoid flushing here. It make