[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571979#comment-17571979
]
Benchao Li commented on FLINK-18202:
[~maosuhan] Could you open a following issue for the document?
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571976#comment-17571976
]
Benchao Li commented on FLINK-18202:
fixed via 5c87b69b5300e8678629aa8b769d60ec2fdbf3d1 (master)
>
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444993#comment-17444993
]
Martijn Visser commented on FLINK-18202:
[~maosuhan] I can look for a committer that can do a
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17444985#comment-17444985
]
Suhan Mao commented on FLINK-18202:
---
I think [https://github.com/apache/flink/pull/14376] is a good
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443608#comment-17443608
]
Martijn Visser commented on FLINK-18202:
[~complone] I've assigned it to you. Looking forward to
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443014#comment-17443014
]
xingyuan cheng commented on FLINK-18202:
cc [~jark] [~maosuhan] [~libenchao]
Hello, everyone.
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335619#comment-17335619
]
Jark Wu commented on FLINK-18202:
-
cc [~lirui]
> Introduce Protobuf format
> -
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324620#comment-17324620
]
Flink Jira Bot commented on FLINK-18202:
This issue is assigned but has not received an update
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248936#comment-17248936
]
Suhan Mao commented on FLINK-18202:
---
[~syucream] That is a good idea! I think "protobuf" identifier
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248882#comment-17248882
]
Ryo Okubo commented on FLINK-18202:
---
That's a great job! I will send some feedbacks on the PR. BTW how
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248805#comment-17248805
]
Suhan Mao commented on FLINK-18202:
---
[~libenchao]. [~jark]
I created a PR for this issue. The PR
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247264#comment-17247264
]
Jark Wu commented on FLINK-18202:
-
Hi [~libenchao], I think we should better to discuss the public APIs
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247243#comment-17247243
]
Benchao Li commented on FLINK-18202:
Thanks [~maosuhan] for your detailed comparisons, I also prefer
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17247244#comment-17247244
]
Benchao Li commented on FLINK-18202:
[~syucream] Thanks for your interest, maybe you can help
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246991#comment-17246991
]
Jark Wu commented on FLINK-18202:
-
#2 sounds good to me. I think maintainability and stability is more
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246504#comment-17246504
]
Ryo Okubo commented on FLINK-18202:
---
Hi all, I'm trying the flink-pb implementation, especially
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246418#comment-17246418
]
Suhan Mao commented on FLINK-18202:
---
I will give an introduction about 3 ways:
1. DynamicMessage and
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245874#comment-17245874
]
Benchao Li commented on FLINK-18202:
I have a discussion with [~maosuhan] offline, and we can see
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235531#comment-17235531
]
Suhan Mao commented on FLINK-18202:
---
[~twalthr] [~libenchao]
I have finished the first version of
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234445#comment-17234445
]
Suhan Mao commented on FLINK-18202:
---
[~twalthr] Sure. It will be an honor to contribute this feature.
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233609#comment-17233609
]
Timo Walther commented on FLINK-18202:
--
[~maosuhan] can you share your implementation with us? I
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233527#comment-17233527
]
Suhan Mao commented on FLINK-18202:
---
I have some experience and already implemented the code of
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178143#comment-17178143
]
tartarus commented on FLINK-18202:
--
Hi, all
A little suggestion, I think it is necessary to support
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175975#comment-17175975
]
liufangliang commented on FLINK-18202:
--
Hi [~libenchao] [~FrankZou] [~jark] , Sounds good to me. if
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175480#comment-17175480
]
Jark Wu commented on FLINK-18202:
-
[~libenchao], I think a simple design docuementation is enough. The
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175425#comment-17175425
]
Benchao Li commented on FLINK-18202:
[~jark] Do you think that we need to open a FLIP for this
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175424#comment-17175424
]
Benchao Li commented on FLINK-18202:
After an offline discussion with [~FrankZou], we think that
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172450#comment-17172450
]
Benchao Li commented on FLINK-18202:
[~liufangliang] Yes, we can derive the field names from
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172448#comment-17172448
]
Benchao Li commented on FLINK-18202:
[~FrankZou]
Regarding the performance, I did some simple
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166167#comment-17166167
]
liufangliang commented on FLINK-18202:
--
Hi [~libenchao] , here's my oponion:
1.2 & 1.3: I support
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165170#comment-17165170
]
Zou commented on FLINK-18202:
-
Hi [~libenchao] , here's my point:
1.1 I think it is convenient for both
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164854#comment-17164854
]
Benchao Li commented on FLINK-18202:
[~jark] Sure, then we'll leave the schema derivation to the
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164368#comment-17164368
]
Jark Wu commented on FLINK-18202:
-
Regarding to Schema derivation, I think this is an orthogonal big
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164310#comment-17164310
]
Benchao Li commented on FLINK-18202:
Hi all,
Sorry about the late reply, I would like to resume the
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147354#comment-17147354
]
liufangliang commented on FLINK-18202:
--
For reference
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147191#comment-17147191
]
liufangliang commented on FLINK-18202:
--
Hi [~libenchao] ,
Currently protobuf only supports C++
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147176#comment-17147176
]
liufangliang commented on FLINK-18202:
--
[~tartarus] sorry for later reply .
several fixed formats
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143672#comment-17143672
]
shaokan cao commented on FLINK-18202:
-
thanks [~libenchao]
> Introduce Protobuf format
>
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143671#comment-17143671
]
Benchao Li commented on FLINK-18202:
[~caoshaokan] Of course, feel free to join the discussions and
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143637#comment-17143637
]
shaokan cao commented on FLINK-18202:
-
[~libenchao] ,i'm interest with this feature,can i join it.
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142995#comment-17142995
]
tartarus commented on FLINK-18202:
--
[~liufangliang] I'm curious which way did you implement it?
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140271#comment-17140271
]
Benchao Li commented on FLINK-18202:
[~FrankZou] It's great to hear that you are also interested in
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139374#comment-17139374
]
Zou commented on FLINK-18202:
-
Big +1 for this feature! And I also want to make some contributions if
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136567#comment-17136567
]
liufangliang commented on FLINK-18202:
--
Thanks [~libenchao] for your reply , happy to join ，this
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135768#comment-17135768
]
Benchao Li commented on FLINK-18202:
[~liufangliang] Thanks for addressing this issue, it would be
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135671#comment-17135671
]
liufangliang commented on FLINK-18202:
--
+1 , [~libenchao] [~nicholasjiang] I think it is necessary
[
https://issues.apache.org/jira/browse/FLINK-18202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128960#comment-17128960
]
Benchao Li commented on FLINK-18202:
[~nicholasjiang] I think we need to support both 2&3. I'm not
47 matches
Mail list logo
