[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-29 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222770#comment-17222770 ] Piotr Nowojski commented on FLINK-19671: I've reverted the contested change. As we discussed

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-28 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222058#comment-17222058 ] Aljoscha Krettek commented on FLINK-19671: -- There was this discussion where I presented the

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-27 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221351#comment-17221351 ] Piotr Nowojski commented on FLINK-19671: But: 1. there was no discussion about changing the the

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-27 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221317#comment-17221317 ] Aljoscha Krettek commented on FLINK-19671: -- Those are more arguments for having an opinionated,

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-26 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220997#comment-17220997 ] Chesnay Schepler commented on FLINK-19671: -- I've had similar issues with line wrapping, and by

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-26 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220979#comment-17220979 ] Piotr Nowojski commented on FLINK-19671: I've just stumbled across this issue. Suddenly IntelliJ

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-26 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220750#comment-17220750 ] Aljoscha Krettek commented on FLINK-19671: -- I'm afraid the ML discussion has fizzled out, as

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216583#comment-17216583 ] Zhu Zhu commented on FLINK-19671: - I agree that we should have a rule which is easy to apply

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-19 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216548#comment-17216548 ] Aljoscha Krettek commented on FLINK-19671: -- I have used 8 for a long time because we don't have

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216516#comment-17216516 ] Zhu Zhu commented on FLINK-19671: - Hi [~aljoscha], I found the continuation indentation is set to 8,