[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-21 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349061#comment-17349061 ] Jark Wu commented on FLINK-22737: - Sounds make sense to me. > Add support for CURRENT_

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-28 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353138#comment-17353138 ] Ingo Bürk commented on FLINK-22737: --- I decided with [~twalthr] that we'll make this fu

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-28 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353222#comment-17353222 ] Ingo Bürk commented on FLINK-22737: --- [~jark] What do you think about this proposal? Th

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-28 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353228#comment-17353228 ] Timo Walther commented on FLINK-22737: -- Small correction: The alternative would be

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353304#comment-17353304 ] Jark Wu commented on FLINK-22737: - Hi [~airblader], [~twalthr], I prefer to return TIMES

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-28 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353334#comment-17353334 ] Ingo Bürk commented on FLINK-22737: --- Thanks for your input [~jark]! I discussed this w

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-28 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353343#comment-17353343 ] David Anderson commented on FLINK-22737: I like [~jark]'s approach. And it seems

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-28 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353346#comment-17353346 ] Ingo Bürk commented on FLINK-22737: --- [~alpinegizmo] What would "MIN_VALUE" be in case

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-28 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353405#comment-17353405 ] David Anderson commented on FLINK-22737: Semantically, I would argue that return

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353427#comment-17353427 ] Jark Wu commented on FLINK-22737: - I have some concerns when returning NULL, because it

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-28 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353485#comment-17353485 ] Ingo Bürk commented on FLINK-22737: --- I have to admit that I find it quite odd to retur

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354250#comment-17354250 ] Ingo Bürk commented on FLINK-22737: --- I discussed this again with Timo, and we will go

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354265#comment-17354265 ] Timo Walther commented on FLINK-22737: -- I'm against returning 0 as the initial wate

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread JING ZHANG (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354301#comment-17354301 ] JING ZHANG commented on FLINK-22737: [~twalthr] [~jark] [~airblader] Thanks for your

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354306#comment-17354306 ] Jark Wu commented on FLINK-22737: - Thanks [~twalthr]. I'm also fine with returning {{NUL

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354307#comment-17354307 ] Jark Wu commented on FLINK-22737: - {{FROM T where rowtime >= CURRENT_WATERMARK}} is not

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread JING ZHANG (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354341#comment-17354341 ] JING ZHANG commented on FLINK-22737: [~jark] Would you please explain a little more

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354361#comment-17354361 ] Jark Wu commented on FLINK-22737: - I thought it wrong. I agree with [~qingru zhang]. The

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354370#comment-17354370 ] Timo Walther commented on FLINK-22737: -- As I said before, I would be fine with Long

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354813#comment-17354813 ] Ingo Bürk commented on FLINK-22737: --- Just for completeness, this is how the SQL client

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354876#comment-17354876 ] Leonard Xu commented on FLINK-22737: * -1 for using *NULL* which will bring the thre

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-05-31 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354878#comment-17354878 ] Timo Walther commented on FLINK-22737: -- After thinking about this topic again, also

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-06-01 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354893#comment-17354893 ] Ingo Bürk commented on FLINK-22737: --- I would really like avoiding going back to BIGINT

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-06-01 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354929#comment-17354929 ] Jark Wu commented on FLINK-22737: - It seems no option can make every one happy. I woul

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-06-01 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354949#comment-17354949 ] David Anderson commented on FLINK-22737: [~twalthr] has convinced me, and I (rel

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-06-01 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354958#comment-17354958 ] Ingo Bürk commented on FLINK-22737: --- Thanks everyone for the productive discussion. I

[jira] [Commented] (FLINK-22737) Add support for CURRENT_WATERMARK to SQL

2021-06-01 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355041#comment-17355041 ] Jark Wu commented on FLINK-22737: - Thanks [~airblader] for the summary. Sounds good to m