[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738851#comment-17738851
]
loyi commented on FLINK-23190:
--
[~heigebupahei] I implemented it in flink1.13.2, not sure whether it is
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738094#comment-17738094
]
yuanfenghu commented on FLINK-23190:
{code:java}
//代码占位符
@Overridepublic List allocateSlotsFor(
List
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738092#comment-17738092
]
yuanfenghu commented on FLINK-23190:
[~loyi]
@Overridepublic List allocateSlotsFor(
List
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738090#comment-17738090
]
yuanfenghu commented on FLINK-23190:
[~loyi]
no, i just use
```
private Collection
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738089#comment-17738089
]
yuanfenghu commented on FLINK-23190:
[~loyi]
no, i just use
```
private Collection
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737930#comment-17737930
]
loyi commented on FLINK-23190:
--
[~heigebupahei] Thanks for your trying. Have you opened the config
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737632#comment-17737632
]
yuanfenghu commented on FLINK-23190:
[~loyi] I think there are other issues to consider
# Flink
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737625#comment-17737625
]
yuanfenghu commented on FLINK-23190:
loyi
I think there are still some problems, my test
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737623#comment-17737623
]
yuanfenghu commented on FLINK-23190:
[~loyi] 我认为有些缺陷，我之前也做过类似的工作，比如
> Make task-slot allocation
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737413#comment-17737413
]
loyi commented on FLINK-23190:
--
[~heigebupahei] Looking forward to your feedback. :)
> Make task-slot
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736826#comment-17736826
]
yuanfenghu commented on FLINK-23190:
[~loyi] Thank you. In our scenario, there will also be
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503952#comment-17503952
]
loyi commented on FLINK-23190:
--
Thank you both for your kind replies.
> Make task-slot allocation much
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503552#comment-17503552
]
Chesnay Schepler commented on FLINK-23190:
--
[~loyi] The project is currently occupied with
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502807#comment-17502807
]
Till Rohrmann commented on FLINK-23190:
---
Sorry for not getting back to your PR [~loyi].
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502196#comment-17502196
]
loyi commented on FLINK-23190:
--
Hi [~trohrmann] , I am sorry to disturb you. Is the feature still be
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17440937#comment-17440937
]
loyi commented on FLINK-23190:
--
Hi, [~trohrmann] , it seems to be a few months since we last talked about
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407022#comment-17407022
]
loyi commented on FLINK-23190:
--
Get it . Thanks.
> Make task-slot allocation much more evenly
>
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406713#comment-17406713
]
Till Rohrmann commented on FLINK-23190:
---
Thanks [~loyi]. I cannot promise that I'll get to it this
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406616#comment-17406616
]
loyi commented on FLINK-23190:
--
I have submitted a [PR|https://github.com/apache/flink/pull/16929] for this
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401642#comment-17401642
]
loyi commented on FLINK-23190:
--
[~trohrmann] I'm willing to contribute this feature.
> Make task-slot
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401604#comment-17401604
]
Till Rohrmann commented on FLINK-23190:
---
I think this solution is nicer than the previous one with
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397921#comment-17397921
]
loyi commented on FLINK-23190:
--
Thanks for your replying [~trohrmann] :)
For DefaultScheduler :
I
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17396739#comment-17396739
]
Till Rohrmann commented on FLINK-23190:
---
Sorry for my late reply [~loyi]. The distribution looks
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17395691#comment-17395691
]
loyi commented on FLINK-23190:
--
[~trohrmann] hi, do you have a conclusion about this ?
> Make task-slot
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385568#comment-17385568
]
Till Rohrmann commented on FLINK-23190:
---
Thanks for the details [~loyi]. I'll try to take a look
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17384608#comment-17384608
]
loyi commented on FLINK-23190:
--
[~trohrmann] Hello, should i provide more results? Can these prove that
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381794#comment-17381794
]
loyi commented on FLINK-23190:
--
[~trohrmann] Thanks for your patience. I have implement a version based
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381661#comment-17381661
]
loyi commented on FLINK-23190:
--
Job description:
// flink run -yjm 2048 -ytm 2048 -ys 4 -ynm demo-job -m
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381369#comment-17381369
]
Till Rohrmann commented on FLINK-23190:
---
{{cluster.evenly-spread-out-slots}} also works for active
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381353#comment-17381353
]
loyi commented on FLINK-23190:
--
[~trohrmann] Here is the differences:
1.
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380560#comment-17380560
]
Till Rohrmann commented on FLINK-23190:
---
I think it should be doable to improve the slot
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380372#comment-17380372
]
loyi commented on FLINK-23190:
--
Hi, [~trohrmann] Sorry about my poor englist again, maybe I didn’t
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379093#comment-17379093
]
loyi commented on FLINK-23190:
--
[~trohrmann] You are right!
If a job need 40 phy-slots, and specified ys 3
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379059#comment-17379059
]
Till Rohrmann commented on FLINK-23190:
---
The {{ResourceManager}} decides which {{TaskExecutor}}
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379046#comment-17379046
]
loyi commented on FLINK-23190:
--
[~trohrmann] hi, maybe we don't need to add a extra strategy for the
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379015#comment-17379015
]
Till Rohrmann commented on FLINK-23190:
---
What would be the strategy for the {{ResourceManager}} to
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378430#comment-17378430
]
loyi commented on FLINK-23190:
--
[~trohrmann] Do you mean the solution couldn't achieve totally evenly
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378091#comment-17378091
]
Till Rohrmann commented on FLINK-23190:
---
Implementing a different slot selection strategy based on
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377343#comment-17377343
]
loyi commented on FLINK-23190:
--
[~trohrmann] thanks for your explanation. I try implement my idea on
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17376468#comment-17376468
]
Till Rohrmann commented on FLINK-23190:
---
{{cluster.evenly-spread-out-slots}} should only work for
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375432#comment-17375432
]
loyi commented on FLINK-23190:
--
[~pnowojski] , i have tried the option you mentioned , it seems just works
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375424#comment-17375424
]
loyi commented on FLINK-23190:
--
Till Rohrmann , seems the solution just works for action resource
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374868#comment-17374868
]
Till Rohrmann commented on FLINK-23190:
---
Thanks for reporting this issue [~loyi]. Have you checked
[
https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374789#comment-17374789
]
Piotr Nowojski commented on FLINK-23190:
[~loyi] have you tried the
44 matches
Mail list logo
