[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730507#comment-17730507 ] jackylau commented on FLINK-26945: -- hi [~twalthr] this pr is long time no one to review it? will you

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705173#comment-17705173 ] jackylau commented on FLINK-26945: -- hi [~twalthr] ,do you have time to help review it? > Add DATE_SUB

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703975#comment-17703975 ] jackylau commented on FLINK-26945: -- hi [~twalthr] , thanks, i know what does the conversionClass means

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703680#comment-17703680 ] Timo Walther commented on FLINK-26945: -- I see the problem is that this is rather an internal

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703653#comment-17703653 ] jackylau commented on FLINK-26945: -- and i I have tried ResolverRule like spark cast to date in advance,

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703649#comment-17703649 ] jackylau commented on FLINK-26945: -- I tried what you said, but it also didn't work . it will throws

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703636#comment-17703636 ] jackylau commented on FLINK-26945: -- hi [~twalthr] , i want to do cast ahead like spark through rules

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703558#comment-17703558 ] Timo Walther commented on FLINK-26945: -- [~jackylau] the input type strategy can insert implicit

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700971#comment-17700971 ] jackylau commented on FLINK-26945: -- hi [~jark] [~twalthr] , when i implement the date_sub builtin

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697823#comment-17697823 ] jackylau commented on FLINK-26945: -- [~jark] , yeap. data_sub can be completely replaced by minus,

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697817#comment-17697817 ] Jark Wu commented on FLINK-26945: - I think the Spark/Hive style date_add/date_sub can be a shortcut for

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697816#comment-17697816 ] Jark Wu commented on FLINK-26945: - The BigQuery style is similar to the Flink function {{TIMESTAMPADD}}:

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697813#comment-17697813 ] jackylau commented on FLINK-26945: -- hi [~jark] , what do think add date_sub/date_add/date_diff like

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694860#comment-17694860 ] jackylau commented on FLINK-26945: -- and there is a bug is times bultin function, which supports this

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694858#comment-17694858 ] jackylau commented on FLINK-26945: -- and i commit a pr [~lsy] what do you think? > Add DATE_SUB

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694857#comment-17694857 ] jackylau commented on FLINK-26945: -- i think it is not good. because the numDays is limit to day. i

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531469#comment-17531469 ] Lichuanliang commented on FLINK-26945: -- [~lsy] I've made a pull request. Please take a review and

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17528460#comment-17528460 ] Lichuanliang commented on FLINK-26945: -- I'm interested in doing this > Add DATE_SUB supported in

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516197#comment-17516197 ] zoucao commented on FLINK-26945: Looking forward to it, It is very useful. > Add DATE_SUB supported in