[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

2022-07-27 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571778#comment-17571778 ] Danny Cranmer commented on FLINK-27536: --- Merged to master, thanks for the contribution

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

2022-07-26 Thread DavidLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571447#comment-17571447 ] DavidLiu commented on FLINK-27536: -- [~dannycranmer]  Please help review this Pull Request again,which

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

2022-07-25 Thread DavidLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571196#comment-17571196 ] DavidLiu commented on FLINK-27536: -- [~dannycranmer] I will open a new Pull Request > Rename method

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

2022-07-22 Thread DavidLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569934#comment-17569934 ] DavidLiu commented on FLINK-27536: -- [~dannycranmer]  please review the feedback in PR. Thanks > Rename

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

2022-07-22 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569849#comment-17569849 ] Danny Cranmer commented on FLINK-27536: --- [~DavidLiu001] thanks for the PR, I have left a comment

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

2022-07-21 Thread DavidLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569805#comment-17569805 ] DavidLiu commented on FLINK-27536: -- https://github.com/apache/flink/pull/20338 > Rename method

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

2022-07-21 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569356#comment-17569356 ] Danny Cranmer commented on FLINK-27536: --- Done. Happy to pickup the review > Rename method

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

2022-07-21 Thread Zichen Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569350#comment-17569350 ] Zichen Liu commented on FLINK-27536: Hi [~DavidLiu001], awesome. [~dannycranmer] would you mind

[jira] [Commented] (FLINK-27536) Rename method parameter in AsyncSinkWriter

2022-07-21 Thread DavidLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569347#comment-17569347 ] DavidLiu commented on FLINK-27536: -- Hello,Zichen Liu. I would like to deal with it.  Can you assign