[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740095#comment-17740095 ] Jacky Lau commented on FLINK-32257: --- [~dwysakowicz] i can support the complex type compare like spark,

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740087#comment-17740087 ] Dawid Wysakowicz commented on FLINK-32257: -- I'd rather stick to what is supported today. I am

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740085#comment-17740085 ] Jacky Lau commented on FLINK-32257: --- [~dwysakowicz] after read the

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740075#comment-17740075 ] Dawid Wysakowicz commented on FLINK-32257: -- [~jackylau] Please read through:

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740007#comment-17740007 ] Jacky Lau commented on FLINK-32257: --- hi [~dwysakowicz] , the array_max return type has fixed and

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740005#comment-17740005 ] Jacky Lau commented on FLINK-32257: --- hi [~hanyuzheng] MAP_ENTRIES i have already supported and merged

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739229#comment-17739229 ] Hanyu Zheng commented on FLINK-32257: - Hi [~jackylau], I am also working on collection functions. I

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738987#comment-17738987 ] Jacky Lau commented on FLINK-32257: --- hi [~dwysakowicz] if you have time , could you help review this ?

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738985#comment-17738985 ] Jacky Lau commented on FLINK-32257: --- [~dwysakowicz] thanks very much. > Add ARRAY_MAX support in SQL

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738983#comment-17738983 ] Dawid Wysakowicz commented on FLINK-32257: -- Thank you for checking this PR by the way! > Add

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738980#comment-17738980 ] Dawid Wysakowicz commented on FLINK-32257: -- I'd love to spend more time reviewing tickets, but

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738978#comment-17738978 ] Jacky Lau commented on FLINK-32257: --- hi [~dwysakowicz] i create a issue to fix this

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738977#comment-17738977 ] Matthias Pohl commented on FLINK-32257: --- Got it - thanks for clarification :) > Add ARRAY_MAX

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738974#comment-17738974 ] Dawid Wysakowicz commented on FLINK-32257: -- The thing is I merged it again with a fix for

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738975#comment-17738975 ] Dawid Wysakowicz commented on FLINK-32257: -- Merged again with fixed tests in:

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738967#comment-17738967 ] Matthias Pohl commented on FLINK-32257: --- Just for me to understand: We reverted the change

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738963#comment-17738963 ] Dawid Wysakowicz commented on FLINK-32257: -- You're right [~jackylau] Do you mind creating a

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738959#comment-17738959 ] Jacky Lau commented on FLINK-32257: --- hi guys [~hanyuzheng] [~dwysakowicz] [~Sergey Nuyanzin] [~mapohl] 

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738633#comment-17738633 ] Matthias Pohl commented on FLINK-32257: --- Just for the sake of documentation: revert on master:

[jira] [Commented] (FLINK-32257) Add ARRAY_MAX support in SQL & Table API

[ https://issues.apache.org/jira/browse/FLINK-32257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738632#comment-17738632 ] Sergey Nuyanzin commented on FLINK-32257: - [~hanyuzheng], [~dwysakowicz] I'm really sorry