[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-04 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803187#comment-17803187 ] Martijn Visser commented on FLINK-33490: Sounds good to me, thank you! > Valid

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-04 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802610#comment-17802610 ] xuyang commented on FLINK-33490: Hi, [~martijnvisser] and [~fsk119] . Thank you for your

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-03 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802490#comment-17802490 ] Shengkai Fang commented on FLINK-33490: --- Hi, [~martijnvisser]. Thanks a lot for yo

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-03 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802146#comment-17802146 ] Martijn Visser commented on FLINK-33490: [~fsk119] I'm not suggesting to have a

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-03 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802136#comment-17802136 ] Shengkai Fang commented on FLINK-33490: --- Hi, [~martijnvisser]. I think this issue

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-02 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801720#comment-17801720 ] Martijn Visser commented on FLINK-33490: [~xuyangzhong] So we have a list of cur

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2024-01-01 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801633#comment-17801633 ] xuyang commented on FLINK-33490: Hi, [~martijnvisser] . IIRC, the small Flip that we wan

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-28 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800988#comment-17800988 ] Martijn Visser commented on FLINK-33490: I'm confused about FLINK-33740 - Have w

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-22 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799704#comment-17799704 ] xuyang commented on FLINK-33490: Agree with you, [~libenchao] . We shouldn't throw an ex

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799688#comment-17799688 ] Benchao Li commented on FLINK-33490: [~xuyangzhong] No, I mean  {code:SQL} CREATE VI

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-21 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799679#comment-17799679 ] xuyang commented on FLINK-33490: Hi, [~libenchao] .IIUC, do you mean we need to support

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799398#comment-17799398 ] Benchao Li commented on FLINK-33490: The standard states that: {quote}i) If any two

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799240#comment-17799240 ] Shengkai Fang commented on FLINK-33490: --- Merged into master: a4fe01cb9d678b293107b

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-04 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792841#comment-17792841 ] xuyang commented on FLINK-33490: OK, it seems that a flip with aligning sql usages to li

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-24 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789494#comment-17789494 ] lincoln lee commented on FLINK-33490: - Here're my two cents: from my previous refere

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789366#comment-17789366 ] Martijn Visser commented on FLINK-33490: I think it would be a good practice to

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-23 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789326#comment-17789326 ] Benchao Li commented on FLINK-33490: I agree mostly, I don't have a strong opinion w

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-22 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788987#comment-17788987 ] xuyang commented on FLINK-33490: Hi, [~libenchao] [~fsk119] . I think we can pick some

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-22 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788984#comment-17788984 ] Shengkai Fang commented on FLINK-33490: --- +1 to clarify the behaviour. > Validate

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788980#comment-17788980 ] Benchao Li commented on FLINK-33490: Great, thanks [~xuyangzhong] for the investigat

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-21 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788648#comment-17788648 ] xuyang commented on FLINK-33490: Hi, [~libenchao] .  I test the sql you provide and som

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788253#comment-17788253 ] Benchao Li commented on FLINK-33490: I'm wondering what the expected behavior for `

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-15 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786327#comment-17786327 ] xuyang commented on FLINK-33490: Hi, [~fsk119] , Can I take this jira? > Validate the n