[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15442326#comment-15442326
]
ASF GitHub Bot commented on FLINK-4440:
---
Github user mushketyk commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15442325#comment-15442325
]
ASF GitHub Bot commented on FLINK-4440:
---
Github user mushketyk closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439188#comment-15439188
]
Ivan Mushketyk commented on FLINK-4440:
---
It's ok with me. I'll close the JIRA issue and the PR.
>
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439178#comment-15439178
]
Vasia Kalavri commented on FLINK-4440:
--
Alright, makes sense. Let's close this then. Is that fine
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437533#comment-15437533
]
Greg Hogan commented on FLINK-4440:
---
I think it is good to be explicit when assigning the vertex and
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437307#comment-15437307
]
Vasia Kalavri commented on FLINK-4440:
--
I don't have a strong opinion against adding the {{create}}
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434938#comment-15434938
]
Greg Hogan commented on FLINK-4440:
---
The referenced code from {{Graph}} could also use the diamond
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433851#comment-15433851
]
Ivan Mushketyk commented on FLINK-4440:
---
I assume that it will be used for instantiating in test
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432718#comment-15432718
]
Greg Hogan commented on FLINK-4440:
---
Yes, I stand corrected.
When would these new methods be used? When
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431625#comment-15431625
]
Ivan Mushketyk commented on FLINK-4440:
---
[~greghogan]
On the second thought,
We can define a
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430534#comment-15430534
]
Ivan Mushketyk commented on FLINK-4440:
---
Hi [~greg hogan],
I think you have a good point. I'll
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429953#comment-15429953
]
Greg Hogan commented on FLINK-4440:
---
Flink supports a minimum of Java 7 (which is end-of-life) so the
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429794#comment-15429794
]
ASF GitHub Bot commented on FLINK-4440:
---
Github user mushketyk commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429793#comment-15429793
]
Ivan Mushketyk commented on FLINK-4440:
---
Pull request: https://github.com/apache/flink/pull/2398
>
14 matches
Mail list logo
