[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-19 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503625#comment-15503625 ] Simone Robutti commented on FLINK-4565: --- Considering my current schedule and the importance of this

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-19 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503481#comment-15503481 ] Timo Walther commented on FLINK-4565: - I looked into the code for this issue. It would be very tricky

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474327#comment-15474327 ] Timo Walther commented on FLINK-4565: - I'm very sorry. Maybe I underestimated this issue after

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-08 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474082#comment-15474082 ] Simone Robutti commented on FLINK-4565: --- After a couple of days of work I believe this task is a bit

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473966#comment-15473966 ] Timo Walther commented on FLINK-4565: - Yes, this would fail then. But I think there is no other good

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-08 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473867#comment-15473867 ] Simone Robutti commented on FLINK-4565: --- I'm no expert in the Table API, but if a user doesn't

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-08 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473833#comment-15473833 ] Timo Walther commented on FLINK-4565: - I think it is ok, if you just parse the table name and

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-08 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473685#comment-15473685 ] Simone Robutti commented on FLINK-4565: --- I defined this parser combinator rule ```lazy val

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-07 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470472#comment-15470472 ] Simone Robutti commented on FLINK-4565: --- That's exactly why I'm asking it: I had no idea what to use

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-07 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470437#comment-15470437 ] Fabian Hueske commented on FLINK-4565: -- I thought rather of something like this: {{ds1.where('a in

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-07 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470412#comment-15470412 ] Simone Robutti commented on FLINK-4565: --- The resulting API should look like `ds1.join(ds2).where('a

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469879#comment-15469879 ] Timo Walther commented on FLINK-4565: - It seems my answer was to late. Yes, I would also go for the

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469873#comment-15469873 ] Timo Walther commented on FLINK-4565: - Calcite translates the IN operator in

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-07 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469851#comment-15469851 ] Simone Robutti commented on FLINK-4565: --- I imagined it could happen that way and I was going to open

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-07 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469836#comment-15469836 ] Fabian Hueske commented on FLINK-4565: -- SQL {{IN}} does not require a special implementation because

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-07 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469797#comment-15469797 ] Simone Robutti commented on FLINK-4565: --- Actually the confusing part is that the translation to the

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-06 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469402#comment-15469402 ] Jark Wu commented on FLINK-4565: I think what is confusing [~chobeat] is what's "IN" 's counterpart in

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-06 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467945#comment-15467945 ] Simone Robutti commented on FLINK-4565: --- I haven't assigned the issue to myself because I'm still

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-06 Thread Konstantin Boudnik (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467913#comment-15467913 ] Konstantin Boudnik commented on FLINK-4565: --- If someone starts working on an issue, shouldn't it

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-06 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467383#comment-15467383 ] Timo Walther commented on FLINK-4565: - tableEnv.sql(...) returns a Table containing a LogicalRelNode

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-06 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467236#comment-15467236 ] Simone Robutti commented on FLINK-4565: --- Ok, the testing part seems easy and straightforward. I'm

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-06 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467059#comment-15467059 ] Timo Walther commented on FLINK-4565: - Hi [~chobeat], yes I think this issue is good for a beginner.

[jira] [Commented] (FLINK-4565) Support for SQL IN operator

2016-09-06 Thread Simone Robutti (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467016#comment-15467016 ] Simone Robutti commented on FLINK-4565: --- I would like to take care of this issue to get my hands

<    1   2