[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2017-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994788#comment-15994788 ] ASF GitHub Bot commented on FLINK-4604: --- Github user ex00 commented on the issue:

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2017-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994784#comment-15994784 ] ASF GitHub Bot commented on FLINK-4604: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2017-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993043#comment-15993043 ] ASF GitHub Bot commented on FLINK-4604: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2017-04-21 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978405#comment-15978405 ] Anton Mushin commented on FLINK-4604: - Hi [~twalthr], Could you look my PR for this issue, please? >

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2017-04-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969972#comment-15969972 ] ASF GitHub Bot commented on FLINK-4604: --- Github user ex00 commented on the issue:

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2017-03-27 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942740#comment-15942740 ] Anton Mushin commented on FLINK-4604: - Hi everyone, Calcite 1.12 has been release:

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2017-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851394#comment-15851394 ] ASF GitHub Bot commented on FLINK-4604: --- GitHub user ex00 opened a pull request:

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2017-01-11 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817633#comment-15817633 ] Anton Mushin commented on FLINK-4604: - Hi [~twalthr]. Do you suggest use *Decorrelator class for Flink

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2017-01-10 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815229#comment-15815229 ] Timo Walther commented on FLINK-4604: - Any news on this [~anmu]? You could solve this issue

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-11-22 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15686845#comment-15686845 ] Anton Mushin commented on FLINK-4604: - what if do try return the type of source column instead null?

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-11-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667697#comment-15667697 ] Timo Walther commented on FLINK-4604: - I looked into the problem. If you take a look at

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-11-15 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666872#comment-15666872 ] Timo Walther commented on FLINK-4604: - I think the missing type for {{NULL}} is a Calcite issue.

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-31 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621663#comment-15621663 ] Anton Mushin commented on FLINK-4604: - bq. We can later remove these commits once the original PR got

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615730#comment-15615730 ] Fabian Hueske commented on FLINK-4604: -- Hi [~anmu], thanks for digging into this. Regarding the

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-28 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615302#comment-15615302 ] Anton Mushin commented on FLINK-4604: - For correct calculate standard deviation/variance function need

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-28 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615280#comment-15615280 ] Anton Mushin commented on FLINK-4604: - I found rootcause problems occur only in query with SUM, if in

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-26 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15607653#comment-15607653 ] Anton Mushin commented on FLINK-4604: - Hello [~fhueske], thanks for your answer! I added support

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-21 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595581#comment-15595581 ] Fabian Hueske commented on FLINK-4604: -- Hi [~anmu], I think we can implement and add support for

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-17 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581442#comment-15581442 ] Anton Mushin commented on FLINK-4604: - Do you talking about new issue for support

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-14 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575320#comment-15575320 ] Timo Walther commented on FLINK-4604: - The problem is that the rule translates not only into {{SUM}}

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-13 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572115#comment-15572115 ] Anton Mushin commented on FLINK-4604: - Sorry, I will try explain my problem. I have two tests

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-13 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571502#comment-15571502 ] Anton Mushin commented on FLINK-4604: - I tried use code like as your code and I got exception:

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569021#comment-15569021 ] Timo Walther commented on FLINK-4604: - You cannot use

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-12 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568664#comment-15568664 ] Anton Mushin commented on FLINK-4604: - I tried check function in

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-10 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561815#comment-15561815 ] Timo Walther commented on FLINK-4604: - Yes, I mean {{matches}}. {{DataSetAggregate}} does not support

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-10 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561783#comment-15561783 ] Anton Mushin commented on FLINK-4604: - Do you mean check in

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556725#comment-15556725 ] Timo Walther commented on FLINK-4604: - I think a even nicer solution would be to check the aggregation

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-07 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554768#comment-15554768 ] Anton Mushin commented on FLINK-4604: - I changed method

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-07 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554766#comment-15554766 ] Timo Walther commented on FLINK-4604: - Yes, you are right. We have to make the costs for STDDEV_POP,

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-07 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554574#comment-15554574 ] Anton Mushin commented on FLINK-4604: - I'm think will probably worth consider types of aggregate

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-07 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554418#comment-15554418 ] Anton Mushin commented on FLINK-4604: - Yes, of course. link to commit:

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-06 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552086#comment-15552086 ] Timo Walther commented on FLINK-4604: - Maybe the cost function of {{DataSetAggregate}} is faulty.

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-06 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551943#comment-15551943 ] Timo Walther commented on FLINK-4604: - Ok, it seems that the {{AggregateReduceFunctionsRule}} does

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-06 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551768#comment-15551768 ] Anton Mushin commented on FLINK-4604: - I'm use {{RelOptUtil.toString(relNode)}} for getting plan

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-06 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551706#comment-15551706 ] Timo Walther commented on FLINK-4604: - Your implementation looks good so far. The output of

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-06 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551505#comment-15551505 ] Anton Mushin commented on FLINK-4604: - I have some problem. I added rule in

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-10-04 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544874#comment-15544874 ] Timo Walther commented on FLINK-4604: - Hi [~anmu], 1. Yes, the test should look like the one in your

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-09-30 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536178#comment-15536178 ] Anton Mushin commented on FLINK-4604: - [~twalthr],thanks! I have any question about this issue. 1. Am

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-09-30 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535940#comment-15535940 ] Timo Walther commented on FLINK-4604: - [~anmu] yes sure. I assigned the issue to you. If you need any

[jira] [Commented] (FLINK-4604) Add support for standard deviation/variance

2016-09-30 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535709#comment-15535709 ] Anton Mushin commented on FLINK-4604: - Hello. Could I start to resolve this ticket? > Add support