[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2019-04-02 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807900#comment-16807900 ] Haisheng Yuan commented on FLINK-7730: -- The Calcite issue [CALCITE-2004|https://iss

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206933#comment-16206933 ] ASF GitHub Bot commented on FLINK-7730: --- Github user xccui closed the pull request a

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206932#comment-16206932 ] ASF GitHub Bot commented on FLINK-7730: --- Github user xccui commented on the issue:

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206150#comment-16206150 ] Fabian Hueske commented on FLINK-7730: -- The pressing issue that needs to be fixed bef

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206121#comment-16206121 ] Xingcan Cui commented on FLINK-7730: Hi [~fhueske], more reasons are revealed for thes

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205720#comment-16205720 ] ASF GitHub Bot commented on FLINK-7730: --- Github user xccui commented on a diff in th

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205675#comment-16205675 ] ASF GitHub Bot commented on FLINK-7730: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205674#comment-16205674 ] ASF GitHub Bot commented on FLINK-7730: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205672#comment-16205672 ] ASF GitHub Bot commented on FLINK-7730: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205671#comment-16205671 ] ASF GitHub Bot commented on FLINK-7730: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205613#comment-16205613 ] ASF GitHub Bot commented on FLINK-7730: --- GitHub user xccui opened a pull request:

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205556#comment-16205556 ] Fabian Hueske commented on FLINK-7730: -- Yes, the idea would be to forbid all predicat

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-15 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205239#comment-16205239 ] Xingcan Cui commented on FLINK-7730: Thanks for the discussion, [~fhueske]. I've check

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-15 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205157#comment-16205157 ] Fabian Hueske commented on FLINK-7730: -- This is mainly problem in Calcite (see [this

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-04 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191095#comment-16191095 ] Xingcan Cui commented on FLINK-7730: Sure. I'll consult the Calcite community for this

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191086#comment-16191086 ] Fabian Hueske commented on FLINK-7730: -- Thanks for looking into this [~xccui]! This

[jira] [Commented] (FLINK-7730) TableFunction LEFT OUTER joins with ON predicates are broken

2017-10-01 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187397#comment-16187397 ] Xingcan Cui commented on FLINK-7730: Hi [~fhueske], I've checked the implementation an