Piyush Goyal created FLINK-12681:
------------------------------------

             Summary: Make SimpleCounter thread-safe.
                 Key: FLINK-12681
                 URL: https://issues.apache.org/jira/browse/FLINK-12681
             Project: Flink
          Issue Type: Improvement
            Reporter: Piyush Goyal


While adding metrics to Elasticsearch connector we noticed that the 
SimpleCounter which seems like the main implementation of Counter interface is 
not thread-safe. It makes it tricky/expensive to use it in a multi-threaded 
context. 

 

It should be a very simple change to make it thread-safe, and the performance 
benefit (if any) of keeping it thread-unsafe doesn't seem worth the extra care 
to use it in a multithreaded context. What do you think ?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to