[ https://issues.apache.org/jira/browse/FLINK-34715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonard Xu resolved FLINK-34715. -------------------------------- Resolution: Fixed Fixed in flink-cdc(master): 14b81dc6ec804bd516005a177aea00be75df3cc2 > Fix mysql ut about closing BinlogSplitReader > -------------------------------------------- > > Key: FLINK-34715 > URL: https://issues.apache.org/jira/browse/FLINK-34715 > Project: Flink > Issue Type: Improvement > Components: Flink CDC > Reporter: Xin Gong > Assignee: Xin Gong > Priority: Minor > Labels: pull-request-available > Fix For: cdc-3.1.0 > > > BinlogSplitReaderTest#readBinlogSplitsFromSnapshotSplits should test binlog > reader is closed after binlog reader close. But code always test snapshot > split reader is closed. > {code:java} > binlogReader.close(); > assertNotNull(snapshotSplitReader.getExecutorService()); > assertTrue(snapshotSplitReader.getExecutorService().isTerminated());{code} > We shoud change code to > {code:java} > binlogReader.close(); > assertNotNull(binlogReader.getExecutorService()); > assertTrue(binlogReader.getExecutorService().isTerminated()); {code} > -- This message was sent by Atlassian Jira (v8.20.10#820010)