[ https://issues.apache.org/jira/browse/FLINK-14801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jark Wu updated FLINK-14801: ---------------------------- Summary: Improve the local variable name in SqlCreateTable#unparser() (was: flink sql parser unparser func partition frame local variable name mistake) > Improve the local variable name in SqlCreateTable#unparser() > ------------------------------------------------------------ > > Key: FLINK-14801 > URL: https://issues.apache.org/jira/browse/FLINK-14801 > Project: Flink > Issue Type: Improvement > Components: Table SQL / API > Affects Versions: 1.9.1 > Reporter: xiaodao > Assignee: xiaodao > Priority: Trivial > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > > in the class org.apache.flink.sql.parser.ddl.SqlCreateTable#unparse > {code:java} > //代码占位符 > if (this.partitionKeyList != null && this.partitionKeyList.size() > 0) { > writer.newlineAndIndent(); writer.keyword("PARTITIONED BY"); > SqlWriter.Frame withFrame = writer.startList("(", ")"); > this.partitionKeyList.unparse(writer, leftPrec, rightPrec); > writer.endList(withFrame); > writer.newlineAndIndent(); > } > {code} > it's better to modify name withFrame to partitionedByFrame -- This message was sent by Atlassian Jira (v8.3.4#803005)