Myasuka merged PR #24041:
URL: https://github.com/apache/flink/pull/24041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apach
yuchen-ecnu commented on PR #24041:
URL: https://github.com/apache/flink/pull/24041#issuecomment-1897790800
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
yuchen-ecnu commented on PR #24041:
URL: https://github.com/apache/flink/pull/24041#issuecomment-1895891972
Hi @Myasuka , I have added two more tests for `TaskManagerProfilingHandler`
and `TaskManagerProfilingListHandler`.
--
This is an automated message from the Apache Git Service.
To re
yuchen-ecnu commented on PR #24041:
URL: https://github.com/apache/flink/pull/24041#issuecomment-1893540501
Hi @Myasuka , I have reverted the changes of the deprecated function
`requestTaskManagerFileUploadByName`. But in the
`TaskManagerProfilingFileHandler`, the `Time timeout` was used by
Myasuka commented on code in PR #24041:
URL: https://github.com/apache/flink/pull/24041#discussion_r1452465323
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/TaskManagerProfilingFileHandler.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apach
yuchen-ecnu commented on PR #24041:
URL: https://github.com/apache/flink/pull/24041#issuecomment-1892255488
Hi @Myasuka , I have replaced `Time` with `Duraion` in the updated code.
Please have a look if there are any other problems. Thanks.
--
This is an automated message from the Apache
Myasuka commented on code in PR #24041:
URL: https://github.com/apache/flink/pull/24041#discussion_r1451675133
##
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java:
##
@@ -225,17 +225,34 @@ CompletableFuture
requestTaskManagerFileU
flinkbot commented on PR #24041:
URL: https://github.com/apache/flink/pull/24041#issuecomment-1880408069
## CI report:
* 785c67752eaef9d7a13fdd48f613190c9e6ecb82 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
yuchen-ecnu commented on PR #24041:
URL: https://github.com/apache/flink/pull/24041#issuecomment-1880405288
Hi @Myasuka , do you have time to help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
