reswqa merged PR #23927:
URL: https://github.com/apache/flink/pull/23927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1452075751
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexSet.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1452075751
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexSet.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1452075751
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexSet.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
reswqa commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1452042917
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/BufferAccumulator.java:
##
@@ -65,4 +63,11 @@ void receive(
* Cl
reswqa commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1452042605
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/BufferAccumulator.java:
##
@@ -65,4 +63,11 @@ void receive(
* Cl
reswqa commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1452038225
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexSet.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1452012771
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java:
##
@@ -69,10 +69,10 @@ default void notifyPriorityEven
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1452009484
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexSet.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache
reswqa commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1450161095
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java:
##
@@ -291,13 +291,18 @@ public void releaseAllReso
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1450088659
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java:
##
@@ -229,6 +245,14 @@ ResultSubpartition
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1450086954
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java:
##
@@ -301,6 +302,24 @@ public void setMetricGroup(TaskIOMetr
reswqa commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1446953814
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java:
##
@@ -58,6 +59,12 @@ class CreditBasedSequenceNumb
yunfengzhou-hub commented on PR #23927:
URL: https://github.com/apache/flink/pull/23927#issuecomment-1882465840
Hi @reswqa Could you please take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
xintongsong commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1436062729
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexRange.java:
##
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache
TanYuxin-tyx commented on PR #23927:
URL: https://github.com/apache/flink/pull/23927#issuecomment-1869187119
@yunfengzhou-hub Thanks for the update. I have no more comments on the
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1435935387
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java:
##
@@ -1736,7 +1738,8 @@ private RemoteInputC
TanYuxin-tyx commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1435920016
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/NettyConnectionWriterImpl.java:
##
@@ -30,24 +30,33 @@ public clas
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433793487
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/UnionResultSubpartitionViewTest.java:
##
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433794402
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java:
##
@@ -304,7 +306,15 @@ enum DataType {
RECOVERY_COMPLETION(fals
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433753103
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SubpartitionSelector.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Softw
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433752308
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java:
##
@@ -281,15 +271,9 @@ public SingleInputGate(
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433747654
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageConsumerClient.java:
##
@@ -52,33 +55,39 @@ publ
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433743541
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/PartitionRequestClient.java:
##
@@ -62,9 +62,11 @@ void requestSubpartition(
* Notifies
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433740732
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java:
##
@@ -1736,7 +1738,8 @@ private RemoteInputC
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433735764
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java:
##
@@ -100,7 +102,12 @@ void testCancelPartitionReques
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433736474
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexRange.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apac
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433659493
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartition.java:
##
@@ -533,7 +533,7 @@ public void close() {
}
yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433656381
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexSet.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache
TanYuxin-tyx commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1432220667
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java:
##
@@ -304,7 +306,15 @@ enum DataType {
RECOVERY_COMPLETION(false,
TanYuxin-tyx commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1431327842
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionIndexSet.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache So
yunfengzhou-hub commented on PR #23927:
URL: https://github.com/apache/flink/pull/23927#issuecomment-1862278523
Hi @TanYuxin-tyx could you please take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
flinkbot commented on PR #23927:
URL: https://github.com/apache/flink/pull/23927#issuecomment-1855302232
## CI report:
* 85ba4659f937d58dd510aa63009c3939bc085300 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
33 matches
Mail list logo
