flinkbot commented on PR #24690:
URL: https://github.com/apache/flink/pull/24690#issuecomment-2066354887
## CI report:
* 5fa3b48c1caed9d9e4ff9b31c1b8640318c18555 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Zakelly commented on PR #24690:
URL: https://github.com/apache/flink/pull/24690#issuecomment-2068416578
Rebased master to resolve conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
jectpro7 commented on PR #24690:
URL: https://github.com/apache/flink/pull/24690#issuecomment-2070594485
Hi @Zakelly, the code si LGTM, I have one question, why didn't leverage the
capability of Reactor for these kind of async callback? It seems very similar
to me, anything I missed?
--
Zakelly commented on PR #24690:
URL: https://github.com/apache/flink/pull/24690#issuecomment-2071298219
> Hi @Zakelly, the code si LGTM, I have one question, why didn't leverage
the capability of Reactor for these kind of async callback? It seems very
similar to me, anything I missed? just
jectpro7 commented on PR #24690:
URL: https://github.com/apache/flink/pull/24690#issuecomment-2071773582
@Zakelly yes it is Project Reactor, I totally understand your concerns, we
don't need too many heavy and fancy staff, but what we need just only the
[reactor-core](https://github.com/rea
Zakelly commented on PR #24690:
URL: https://github.com/apache/flink/pull/24690#issuecomment-2072141564
> @Zakelly yes it is Project Reactor, I totally understand your concerns, we
don't need too many heavy and fancy staff, but what we need just only the
[reactor-core](https://github.com/re
jectpro7 commented on PR #24690:
URL: https://github.com/apache/flink/pull/24690#issuecomment-2073002740
I see, the major part of it has done. And in the long term, I believe it is
better than using reactor, as it is more controllable, and easier to extend
regarding to Flink business needs.
masteryhx commented on code in PR #24690:
URL: https://github.com/apache/flink/pull/24690#discussion_r1597852929
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AbstractStateIterator.java:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Found
Zakelly commented on PR #24690:
URL: https://github.com/apache/flink/pull/24690#issuecomment-2107381572
> @Zakelly Thanks for the PR, I have a question about the overall design. It
seems that an iterator can actually be split into several executions. If other
UPDATE are inserted in the midd
Zakelly merged PR #24690:
URL: https://github.com/apache/flink/pull/24690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apach
10 matches
Mail list logo
