boring-cyborg[bot] commented on PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#issuecomment-2128322457
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
luoyuxia merged PR #18:
URL: https://github.com/apache/flink-connector-hive/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@f
WencongLiu commented on PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#issuecomment-2126952619
It seems that the test is canceled. Could you help me trigger it again？
@luoyuxia
--
This is an automated message from the Apache Git Service.
To respond to the message, p
WencongLiu commented on PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#issuecomment-2126933902
@luoyuxia I've updated the pull request. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
WencongLiu commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1611568586
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectSupportSQL11ReservedKeywordAsIdentifierTest.java:
##
@@ -0,0 +1,223 @@
+/
luoyuxia commented on PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#issuecomment-2120403078
> Thanks for the update, +1 for merging.
>
> It seems that the CI failure is unrelated, @luoyuxia could you please help
confirming this?
Yeah. I think the CI failu
luoyuxia commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1594867337
##
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/parse/HiveASTParser.g:
##
@@ -721,6 +722,12 @@ import
org.apache.flink.
luoyuxia commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1594867337
##
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/parse/HiveASTParser.g:
##
@@ -721,6 +722,12 @@ import
org.apache.flink.
WencongLiu commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1606184817
##
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserConstants.java:
##
@@ -30,4 +30,6 @@ public class HiveParser
WencongLiu commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1606184637
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectSupportSQL11ReservedKeywordAsIdentifierTest.java:
##
@@ -0,0 +1,230 @@
+/
WencongLiu commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1606184227
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectSupportSQL11ReservedKeywordAsIdentifierTest.java:
##
@@ -0,0 +1,230 @@
+/
WencongLiu commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1606183796
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectSupportSQL11ReservedKeywordAsIdentifierTest.java:
##
@@ -0,0 +1,230 @@
+/
reswqa commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1602581492
##
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserConstants.java:
##
@@ -30,4 +30,6 @@ public class HiveParserCons
reswqa commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1602576000
##
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserConstants.java:
##
@@ -30,4 +30,6 @@ public class HiveParserCons
reswqa commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1602571412
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectSupportSQL11ReservedKeywordAsIdentifierTest.java:
##
@@ -0,0 +1,230 @@
+/*
+
boring-cyborg[bot] commented on PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#issuecomment-2081434598
Thanks for opening this pull request! Please check out our contributing
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an
16 matches
Mail list logo
