[GitHub] [flink] kezhuw commented on pull request #13776: [FLINK-19717][connectors/common] Fix spurious InputStatus.END_OF_INPUT from SourceReaderBase.pollNext caused by split reader exception

2020-10-28 Thread GitBox
kezhuw commented on pull request #13776: URL: https://github.com/apache/flink/pull/13776#issuecomment-717968401 @StephanEwen @becketqin Anyone has time capacity to review this pr ? @dianfu @rmetzger may want this issue solved before first RC of 1.12.

[GitHub] [flink] flinkbot edited a comment on pull request #13722: [FLINK-19636][coordination] Add DeclarativeSlotPool

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13722: URL: https://github.com/apache/flink/pull/13722#issuecomment-713509789 ## CI report: * fa82dd23b082fc0b4d82de8217831b6ec7624947 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13697: [FLINK-19357][FLINK-19357][fs-connector] Introduce createBucketWriter to BucketsBuilder & Introduce FileLifeCycleListener to Buckets

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13697: URL: https://github.com/apache/flink/pull/13697#issuecomment-712672697 ## CI report: * bd25177243a782fad2e7f9d9ff508e6ba3758303 Azure:

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222129#comment-17222129 ] Robert Metzger commented on FLINK-19854: Yes, I recommend that if the change is likely to break

[GitHub] [flink-statefun] tzulitai closed pull request #168: [FLINK-19692] Write all assigned key groups into the keyed raw stream with a Header.

2020-10-28 Thread GitBox
tzulitai closed pull request #168: URL: https://github.com/apache/flink-statefun/pull/168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] shuiqiangchen commented on pull request #13756: [FLINK-19770][python][test] Changed the PythonProgramOptionTest to be an ITCase.

2020-10-28 Thread GitBox
shuiqiangchen commented on pull request #13756: URL: https://github.com/apache/flink/pull/13756#issuecomment-717898835 @flinkbot run azure This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (FLINK-19858) Add the new table factory for upsert-kafka connector

2020-10-28 Thread Jark Wu (Jira)
Jark Wu created FLINK-19858: --- Summary: Add the new table factory for upsert-kafka connector Key: FLINK-19858 URL: https://issues.apache.org/jira/browse/FLINK-19858 Project: Flink Issue Type:

[jira] [Created] (FLINK-19859) Add documentation for the upsert-kafka connector

2020-10-28 Thread Jark Wu (Jira)
Jark Wu created FLINK-19859: --- Summary: Add documentation for the upsert-kafka connector Key: FLINK-19859 URL: https://issues.apache.org/jira/browse/FLINK-19859 Project: Flink Issue Type: Sub-task

[GitHub] [flink] zentol commented on pull request #13796: [FLINK-19810][CI] Automatically run a basic NOTICE file check on CI

2020-10-28 Thread GitBox
zentol commented on pull request #13796: URL: https://github.com/apache/flink/pull/13796#issuecomment-717906443 Having such a mapping was my idea as well; the explicit failure if a dependency was not found also serves as a reminder to check the license for compatibility. I don't think

[GitHub] [flink] aljoscha commented on a change in pull request #13825: [FLINK-19836] Add SimpleVersionedSerializerTypeSerializerProxy

2020-10-28 Thread GitBox
aljoscha commented on a change in pull request #13825: URL: https://github.com/apache/flink/pull/13825#discussion_r513422586 ## File path: flink-core/src/main/java/org/apache/flink/core/io/SimpleVersionedSerializerTypeSerializerProxy.java ## @@ -0,0 +1,163 @@ +/* + * Licensed

[GitHub] [flink] flinkbot edited a comment on pull request #13644: [FLINK-19542][k8s]Implement LeaderElectionService and LeaderRetrievalService based on Kubernetes API

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13644: URL: https://github.com/apache/flink/pull/13644#issuecomment-708933599 ## CI report: * e60cdbfeb10a33d4df62453679cd309fc39ee198 UNKNOWN * 37efc6f14c55e2bd261b70924c9525c6539447f8 Azure:

[GitHub] [flink] tillrohrmann commented on a change in pull request #13644: [FLINK-19542][k8s]Implement LeaderElectionService and LeaderRetrievalService based on Kubernetes API

2020-10-28 Thread GitBox
tillrohrmann commented on a change in pull request #13644: URL: https://github.com/apache/flink/pull/13644#discussion_r513359598 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java ## @@ -217,6 +230,79 @@ public

[jira] [Updated] (FLINK-19855) Incompatible semantics of channelIndex in UnionInputGate.resumeConsumption and its clients

2020-10-28 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-19855: -- Affects Version/s: (was: 1.11.2) > Incompatible semantics of channelIndex in

[jira] [Updated] (FLINK-19855) Incompatible semantics of channelIndex in UnionInputGate.resumeConsumption and its clients

2020-10-28 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-19855: -- Priority: Minor (was: Major) > Incompatible semantics of channelIndex in

[jira] [Updated] (FLINK-19855) Incompatible semantics of channelIndex in UnionInputGate.resumeConsumption and its clients

2020-10-28 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-19855: -- Description: Given channelIndex only, UnionInputGate has to guess which wrapped input

[GitHub] [flink] flinkbot commented on pull request #13826: [BP-1.11][FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

2020-10-28 Thread GitBox
flinkbot commented on pull request #13826: URL: https://github.com/apache/flink/pull/13826#issuecomment-717947470 ## CI report: * a56eb8b921be50cddf4eaf489da3d24561d0e05d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #13631: [FLINK-19639][table sql/planner]Support SupportsNestedProjectionPushD…

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13631: URL: https://github.com/apache/flink/pull/13631#issuecomment-708335709 ## CI report: * 11b0dfc5a9a5e6aa335f070abfc6781569deb96d UNKNOWN * da9bc2d9410e070611621051bcce5461443335a5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13821: [FLINK-19855][network] Specify channel AND gate in resumeConsumption()

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13821: URL: https://github.com/apache/flink/pull/13821#issuecomment-717893540 ## CI report: * b3158c4d03ddc32916d3d8e584709c50ae82715c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13824: [FLINK-19736] Add the SinkTransformation

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13824: URL: https://github.com/apache/flink/pull/13824#issuecomment-717895470 ## CI report: * a10e3dcdaf7ff215ec455ce60ca7594651ad8d04 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13826: [BP-1.11][FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13826: URL: https://github.com/apache/flink/pull/13826#issuecomment-717947470 ## CI report: * a56eb8b921be50cddf4eaf489da3d24561d0e05d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13825: [FLINK-19836] Add SimpleVersionedSerializerTypeSerializerProxy

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13825: URL: https://github.com/apache/flink/pull/13825#issuecomment-717897004 ## CI report: * 267ea2ff011c4dc74f3209d574d66023835f501e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13073: URL: https://github.com/apache/flink/pull/13073#issuecomment-669650373 ## CI report: * 406f3764484bb5b004988002f620bd20c0c34fd6 Azure:

[jira] [Created] (FLINK-19860) Consider skipping restart and traverse regions which are already being restarted in RestartPipelinedRegionFailoverStrategy

2020-10-28 Thread Andrey Zagrebin (Jira)
Andrey Zagrebin created FLINK-19860: --- Summary: Consider skipping restart and traverse regions which are already being restarted in RestartPipelinedRegionFailoverStrategy Key: FLINK-19860 URL:

[GitHub] [flink] wangyang0918 commented on pull request #13644: [FLINK-19542][k8s]Implement LeaderElectionService and LeaderRetrievalService based on Kubernetes API

2020-10-28 Thread GitBox
wangyang0918 commented on pull request #13644: URL: https://github.com/apache/flink/pull/13644#issuecomment-717892502 @tillrohrmann I have addressed the comments you left and force pushed. They are all promising changes. You could continue the review :)

[GitHub] [flink-statefun] tzulitai removed a comment on pull request #168: [FLINK-19692] Write all assigned key groups into the keyed raw stream with a Header.

2020-10-28 Thread GitBox
tzulitai removed a comment on pull request #168: URL: https://github.com/apache/flink-statefun/pull/168#issuecomment-717889642 Thanks for addressing my comments @igalshilman! I'll merge the PR now  This is an automated

[GitHub] [flink] flinkbot edited a comment on pull request #13750: [FLINK-19394][docs-zh] Translate the 'Monitoring Checkpointing' page of 'Debugging & Monitoring' into Chinese

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13750: URL: https://github.com/apache/flink/pull/13750#issuecomment-714567487 ## CI report: * 1ec411ddcfd58a0ab5f22c7ebe5433439b217d27 Azure:

[GitHub] [flink] flinkbot commented on pull request #13820: [FLINK-19671][codestyle] Revert .editorconfig change violating our coding style

2020-10-28 Thread GitBox
flinkbot commented on pull request #13820: URL: https://github.com/apache/flink/pull/13820#issuecomment-717892896 ## CI report: * c0e721f67b0b4b21b5080900954df10a05890d87 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] dawidwys commented on a change in pull request #13825: [FLINK-19836] Add SimpleVersionedSerializerTypeSerializerProxy

2020-10-28 Thread GitBox
dawidwys commented on a change in pull request #13825: URL: https://github.com/apache/flink/pull/13825#discussion_r513399180 ## File path: flink-core/src/main/java/org/apache/flink/core/io/SimpleVersionedSerializerTypeSerializerProxy.java ## @@ -0,0 +1,163 @@ +/* + * Licensed

[GitHub] [flink] dawidwys commented on a change in pull request #13825: [FLINK-19836] Add SimpleVersionedSerializerTypeSerializerProxy

2020-10-28 Thread GitBox
dawidwys commented on a change in pull request #13825: URL: https://github.com/apache/flink/pull/13825#discussion_r513408053 ## File path: flink-core/src/main/java/org/apache/flink/core/io/SimpleVersionedSerializerTypeSerializerProxy.java ## @@ -0,0 +1,163 @@ +/* + * Licensed

[jira] [Created] (FLINK-19857) FLIP-149: Introduce the upsert-kafka Connector

2020-10-28 Thread Jark Wu (Jira)
Jark Wu created FLINK-19857: --- Summary: FLIP-149: Introduce the upsert-kafka Connector Key: FLINK-19857 URL: https://issues.apache.org/jira/browse/FLINK-19857 Project: Flink Issue Type: New Feature

[GitHub] [flink] zentol commented on pull request #13796: [FLINK-19810][CI] Automatically run a basic NOTICE file check on CI

2020-10-28 Thread GitBox
zentol commented on pull request #13796: URL: https://github.com/apache/flink/pull/13796#issuecomment-717905033 Let's add them all here. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] wangxlong opened a new pull request #13826: [BP-1.11][FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

2020-10-28 Thread GitBox
wangxlong opened a new pull request #13826: URL: https://github.com/apache/flink/pull/13826 ## What is the purpose of the change 1. This is a backport of FLINK-19587, cherry picked from commit d9b0ac97ee4675aebdab1592af663b95fdc5051b. 2. Cherry pick commit

[GitHub] [flink] dawidwys commented on a change in pull request #13825: [FLINK-19836] Add SimpleVersionedSerializerTypeSerializerProxy

2020-10-28 Thread GitBox
dawidwys commented on a change in pull request #13825: URL: https://github.com/apache/flink/pull/13825#discussion_r513419702 ## File path: flink-core/src/main/java/org/apache/flink/core/io/SimpleVersionedSerializerTypeSerializerProxy.java ## @@ -0,0 +1,163 @@ +/* + * Licensed

[GitHub] [flink] SteNicholas commented on a change in pull request #13825: [FLINK-19836] Add SimpleVersionedSerializerTypeSerializerProxy

2020-10-28 Thread GitBox
SteNicholas commented on a change in pull request #13825: URL: https://github.com/apache/flink/pull/13825#discussion_r513419048 ## File path: flink-core/src/main/java/org/apache/flink/core/io/SimpleVersionedSerializerTypeSerializerProxy.java ## @@ -0,0 +1,163 @@ +/* + *

[GitHub] [flink] aljoscha commented on pull request #13073: [FLINK-18820] SourceOperator should send MAX_WATERMARK to downstream operator when closed

2020-10-28 Thread GitBox
aljoscha commented on pull request #13073: URL: https://github.com/apache/flink/pull/13073#issuecomment-717923105 Yes, what @dawidwys sounds correct! Please go for it. This is an automated message from the Apache Git

[GitHub] [flink] flinkbot edited a comment on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13822: URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411 ## CI report: * 612c241aa46314c2822a6f350faf3116c1b5cce0 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13789: [FLINK-19727][table-runtime] Implement ParallelismProvider for sink i…

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13789: URL: https://github.com/apache/flink/pull/13789#issuecomment-716299701 ## CI report: * 934e4f0acf9044de5c6cb73ae25d094396bfc146 UNKNOWN * fd0aa012ed1a15803fe2ed75180d60e6c9fe8d6d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13756: [FLINK-19770][python][test] Changed the PythonProgramOptionTest to be an ITCase.

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13756: URL: https://github.com/apache/flink/pull/13756#issuecomment-714895505 ## CI report: * 37447c7adbd68701dbce2f515ff69af119be5a5b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13722: [FLINK-19636][coordination] Add DeclarativeSlotPool

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13722: URL: https://github.com/apache/flink/pull/13722#issuecomment-713509789 ## CI report: * fa82dd23b082fc0b4d82de8217831b6ec7624947 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13741: [FLINK-19680][checkpointing] Announce timeoutable CheckpointBarriers

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13741: URL: https://github.com/apache/flink/pull/13741#issuecomment-714295796 ## CI report: * fd9a7059d4b4fa7c0760f2c82731436fe1d1312a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13744: [FLINK-19766][table-runtime] Introduce File streaming compaction operators

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13744: URL: https://github.com/apache/flink/pull/13744#issuecomment-714369975 ## CI report: * a01ecf0bade9f8e4a56052fb5b5d25c5034fe511 Azure:

[jira] [Commented] (FLINK-19665) AlternatingCheckpointBarrierHandlerTest.testMetricsAlternation unstable

2020-10-28 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222194#comment-17222194 ] Kezhu Wang commented on FLINK-19665: [~pnowojski] [~rmetzger] Seems that it has been fixed in commit 

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222193#comment-17222193 ] Leonard Xu commented on FLINK-19854: Sorry for the broken tests, I didn't rebase the latest master

[GitHub] [flink] rmetzger commented on pull request #13796: [FLINK-19810][CI] Automatically run a basic NOTICE file check on CI

2020-10-28 Thread GitBox
rmetzger commented on pull request #13796: URL: https://github.com/apache/flink/pull/13796#issuecomment-717967845 How would you integrate such a notice file generating build step into the CI pipeline? - I've quickly looked at building our own shade resource transformer, but it

[GitHub] [flink] StephanEwen commented on pull request #13820: [FLINK-19671][codestyle] Revert .editorconfig change violating our coding style

2020-10-28 Thread GitBox
StephanEwen commented on pull request #13820: URL: https://github.com/apache/flink/pull/13820#issuecomment-717967578 Thanks for spotting this. Is it also an option to adjust the written coding style? I think that having the extra indentation for continuation helps to separate

[GitHub] [flink] flinkbot edited a comment on pull request #13784: [FLINK-19698][connectors/common] API improvements to the Sources.

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13784: URL: https://github.com/apache/flink/pull/13784#issuecomment-716153889 ## CI report: * f0dec4fa5d8e69761377a45df57106a4fbfe8152 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13631: [FLINK-19639][table sql/planner]Support SupportsNestedProjectionPushD…

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13631: URL: https://github.com/apache/flink/pull/13631#issuecomment-708335709 ## CI report: * 11b0dfc5a9a5e6aa335f070abfc6781569deb96d UNKNOWN * da9bc2d9410e070611621051bcce5461443335a5 Azure:

[jira] [Commented] (FLINK-19854) TableScanTest.testTemporalJoinOnUpsertSource fails

2020-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222121#comment-17222121 ] Jark Wu commented on FLINK-19854: - Thanks [~rmetzger], I just know that. Then we have to rebase the pull

[GitHub] [flink] flinkbot commented on pull request #13822: [FLINK-19856][network] Emit EndOfChannelRecoveryEvent

2020-10-28 Thread GitBox
flinkbot commented on pull request #13822: URL: https://github.com/apache/flink/pull/13822#issuecomment-717894411 ## CI report: * 612c241aa46314c2822a6f350faf3116c1b5cce0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] aljoscha commented on a change in pull request #13825: [FLINK-19836] Add SimpleVersionedSerializerTypeSerializerProxy

2020-10-28 Thread GitBox
aljoscha commented on a change in pull request #13825: URL: https://github.com/apache/flink/pull/13825#discussion_r513411521 ## File path: flink-core/src/main/java/org/apache/flink/core/io/SimpleVersionedSerializerTypeSerializerProxy.java ## @@ -0,0 +1,163 @@ +/* + * Licensed

[GitHub] [flink] flinkbot commented on pull request #13826: [BP-1.11][FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

2020-10-28 Thread GitBox
flinkbot commented on pull request #13826: URL: https://github.com/apache/flink/pull/13826#issuecomment-717912982 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] SteNicholas commented on a change in pull request #13825: [FLINK-19836] Add SimpleVersionedSerializerTypeSerializerProxy

2020-10-28 Thread GitBox
SteNicholas commented on a change in pull request #13825: URL: https://github.com/apache/flink/pull/13825#discussion_r513426072 ## File path: flink-core/src/main/java/org/apache/flink/core/io/SimpleVersionedSerializerTypeSerializerProxy.java ## @@ -0,0 +1,163 @@ +/* + *

[GitHub] [flink] flinkbot edited a comment on pull request #13605: [FLINK-19599][table] Introduce Filesystem format factories to integrate new FileSource to table

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13605: URL: https://github.com/apache/flink/pull/13605#issuecomment-707521684 ## CI report: * a9df8a1384eb6306656b4fd952edd4be5d7a857d UNKNOWN * fa0dc913f56aa2567c30073c044f688f9ed74fee Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13791: [FLINK-19749][docs] Improve documentation in 'Table API' page

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13791: URL: https://github.com/apache/flink/pull/13791#issuecomment-716405856 ## CI report: * 054cf380741ac078ac258663fa5f118fa413dbc2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13763: [FLINK-19779][avro] Remove the record_ field name prefix for Confluen…

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13763: URL: https://github.com/apache/flink/pull/13763#issuecomment-715195599 ## CI report: * f004220668e20dcd9860026b69566868d473db33 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13789: [FLINK-19727][table-runtime] Implement ParallelismProvider for sink i…

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13789: URL: https://github.com/apache/flink/pull/13789#issuecomment-716299701 ## CI report: * 934e4f0acf9044de5c6cb73ae25d094396bfc146 UNKNOWN * fd0aa012ed1a15803fe2ed75180d60e6c9fe8d6d Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13756: [FLINK-19770][python][test] Changed the PythonProgramOptionTest to be an ITCase.

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13756: URL: https://github.com/apache/flink/pull/13756#issuecomment-714895505 ## CI report: * 37447c7adbd68701dbce2f515ff69af119be5a5b Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13749: [FLINK-19712][Coordination] Do not restart CREATED executions in RestartPipelinedRegionFailoverStrategy

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13749: URL: https://github.com/apache/flink/pull/13749#issuecomment-714539634 ## CI report: * d1a4068273d54499e90fb54f00044d4955dc5789 Azure:

[jira] [Commented] (FLINK-18286) Implement type inference for functions on composite types

2020-10-28 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222180#comment-17222180 ] Dawid Wysakowicz commented on FLINK-18286: -- GET/FLATTEN was implemented in

[jira] [Assigned] (FLINK-16079) Primary key should use a deterministic name by default

2020-10-28 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-16079: Assignee: (was: Dawid Wysakowicz) > Primary key should use a deterministic

[GitHub] [flink] flinkbot edited a comment on pull request #13620: [hotfix][doc] the first FSDataOutputStream should be FSDataInputStream in FileSystem#L178

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13620: URL: https://github.com/apache/flink/pull/13620#issuecomment-707904494 ## CI report: * 4290129d21b0600e5d17b1c9db54c9416a861b2c Azure:

[jira] [Updated] (FLINK-19822) Remove redundant shuffle for streaming

2020-10-28 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-19822: --- Description: This is similar [FLINK-12575|https://issues.apache.org/jira/browse/FLINK-12575], we

[GitHub] [flink] flinkbot edited a comment on pull request #13819: [hotfix][docs]fix some mistakes in StreamingFileSink

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13819: URL: https://github.com/apache/flink/pull/13819#issuecomment-717834371 ## CI report: * 1967ce552a0ee509cac0e0ef2a3aa29718dcd3ad Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13821: [FLINK-19855][network] Specify channel AND gate in resumeConsumption()

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13821: URL: https://github.com/apache/flink/pull/13821#issuecomment-717893540 ## CI report: * b3158c4d03ddc32916d3d8e584709c50ae82715c Azure:

[GitHub] [flink] JingsongLi commented on a change in pull request #13605: [FLINK-19599][table] Introduce Filesystem format factories to integrate new FileSource to table

2020-10-28 Thread GitBox
JingsongLi commented on a change in pull request #13605: URL: https://github.com/apache/flink/pull/13605#discussion_r513200897 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSource.java ## @@ -88,7 +92,16 @@

[GitHub] [flink] JingsongLi commented on a change in pull request #13605: [FLINK-19599][table] Introduce Filesystem format factories to integrate new FileSource to table

2020-10-28 Thread GitBox
JingsongLi commented on a change in pull request #13605: URL: https://github.com/apache/flink/pull/13605#discussion_r513201092 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSource.java ## @@ -108,13 +121,39

[jira] [Closed] (FLINK-19826) StateFun Dockerfile copies plugins with a specific version instead of a wildcard

2020-10-28 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-19826. --- Fix Version/s: statefun-2.2.1 statefun-2.3.0 Resolution:

[GitHub] [flink] JingsongLi commented on a change in pull request #13605: [FLINK-19599][table] Introduce Filesystem format factories to integrate new FileSource to table

2020-10-28 Thread GitBox
JingsongLi commented on a change in pull request #13605: URL: https://github.com/apache/flink/pull/13605#discussion_r513200486 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/AbstractFileSystemTable.java ## @@ -53,15 +62,75

[jira] [Closed] (FLINK-19827) Allow the harness to start with a user provided Flink configuration

2020-10-28 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-19827. --- Fix Version/s: statefun-2.2.1 statefun-2.3.0 Resolution:

[GitHub] [flink] flinkbot edited a comment on pull request #13307: [FLINK-19078][table-runtime] Import rowtime join temporal operator

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13307: URL: https://github.com/apache/flink/pull/13307#issuecomment-685763264 ## CI report: * dee9ebd0a1947e6580064910a0dace6f5e349c52 Azure:

[GitHub] [flink] JingsongLi commented on a change in pull request #13605: [FLINK-19599][table] Introduce Filesystem format factories to integrate new FileSource to table

2020-10-28 Thread GitBox
JingsongLi commented on a change in pull request #13605: URL: https://github.com/apache/flink/pull/13605#discussion_r513221615 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/filesystem/AbstractFileSystemTable.java ## @@ -53,15 +62,75

[GitHub] [flink] tzulitai commented on pull request #13773: [backport-1.11] [FLINK-19748] Iterating key groups in raw keyed stream on restore fails if some key groups weren't written

2020-10-28 Thread GitBox
tzulitai commented on pull request #13773: URL: https://github.com/apache/flink/pull/13773#issuecomment-717757992 @Antti-Kaikkonen great news, thank you. We'll keep you updated on the JIRA regarding an official release candidate that includes the fixes.

[GitHub] [flink] ShubinRuan opened a new pull request #13817: [HotFix][docs] Fix broken link of docker.md

2020-10-28 Thread GitBox
ShubinRuan opened a new pull request #13817: URL: https://github.com/apache/flink/pull/13817 ## What is the purpose of the change Fix broken link of docker.md The page url is https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/docker.html The markdown

[GitHub] [flink] AHeise commented on a change in pull request #13741: [FLINK-19680][checkpointing] Announce timeoutable CheckpointBarriers

2020-10-28 Thread GitBox
AHeise commented on a change in pull request #13741: URL: https://github.com/apache/flink/pull/13741#discussion_r513238810 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java ## @@ -437,19 +440,20 @@ public

[GitHub] [flink] flinkbot edited a comment on pull request #13812: [FLINK-19674][docs-zh] Translate "Docker" of "Clusters & Depolyment" page into Chinese

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13812: URL: https://github.com/apache/flink/pull/13812#issuecomment-717687160 ## CI report: * 4f66617c4540a4987a5852cf0168f7e3a552c91a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13808: [FLINK-19834] Make the TestSink reusable in all the sink related tests.

2020-10-28 Thread GitBox
flinkbot edited a comment on pull request #13808: URL: https://github.com/apache/flink/pull/13808#issuecomment-717348429 ## CI report: * 202d1f9a25defee69d632dbd8cc497646d9580f6 UNKNOWN * 6386d601a02b699a26feb0b1565a68939262076d Azure:

[jira] [Commented] (FLINK-19847) Can we create a fast support on the Nested table join?

2020-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222027#comment-17222027 ] Jark Wu commented on FLINK-19847: - [~zhoujira86] could you describe your use case and why you need the

[GitHub] [flink] flinkbot commented on pull request #13815: [BP-1.11][FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

2020-10-28 Thread GitBox
flinkbot commented on pull request #13815: URL: https://github.com/apache/flink/pull/13815#issuecomment-717771070 ## CI report: * 60f1b09b2eaca728dcc6a3ca930ec88067d2ef90 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] rmetzger commented on pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build

2020-10-28 Thread GitBox
rmetzger commented on pull request #13779: URL: https://github.com/apache/flink/pull/13779#issuecomment-717770788 Thanks. I'll fix the typo in the commit message & merge it. This is an automated message from the Apache Git

[GitHub] [flink] tillrohrmann commented on pull request #13648: [FLINK-19632] Introduce a new ResultPartitionType for Approximate Local Recovery

2020-10-28 Thread GitBox
tillrohrmann commented on pull request #13648: URL: https://github.com/apache/flink/pull/13648#issuecomment-717803324 Sorry for joining the discussion so late but a couple of questions came up when discussing scheduler changes with Yuan offline. I wanted to ask why we need a special

[jira] [Commented] (FLINK-19671) Update EditorConfig file to be useful

2020-10-28 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222058#comment-17222058 ] Aljoscha Krettek commented on FLINK-19671: -- There was this discussion where I presented the

[jira] [Assigned] (FLINK-19835) Don't emit intermediate watermarks from sources in BATCH execution mode

2020-10-28 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-19835: Assignee: Aljoscha Krettek > Don't emit intermediate watermarks from sources in

[GitHub] [flink] JingsongLi commented on a change in pull request #13605: [FLINK-19599][table] Introduce Filesystem format factories to integrate new FileSource to table

2020-10-28 Thread GitBox
JingsongLi commented on a change in pull request #13605: URL: https://github.com/apache/flink/pull/13605#discussion_r513201380 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetFileSystemFormatFactory.java ## @@ -93,124 +117,17 @@

[GitHub] [flink] rmetzger commented on pull request #13814: [FLINK-19839][e2e] Properly forward test exit code to CI system

2020-10-28 Thread GitBox
rmetzger commented on pull request #13814: URL: https://github.com/apache/flink/pull/13814#issuecomment-717733393 Thanks for the quick review. Merging! This is an automated message from the Apache Git Service. To respond to

[jira] [Closed] (FLINK-19839) e2e test failures are not causing the build to fail

2020-10-28 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-19839. -- Fix Version/s: 1.12.0 Resolution: Fixed Resolved in

[GitHub] [flink] tzulitai edited a comment on pull request #13773: [backport-1.11] [FLINK-19748] Iterating key groups in raw keyed stream on restore fails if some key groups weren't written

2020-10-28 Thread GitBox
tzulitai edited a comment on pull request #13773: URL: https://github.com/apache/flink/pull/13773#issuecomment-717730004 @Antti-Kaikkonen thanks you for trying the branch out. I think the exceptions you encountered are expected in the experiments you've tried out. Can you

[GitHub] [flink] tzulitai edited a comment on pull request #13773: [backport-1.11] [FLINK-19748] Iterating key groups in raw keyed stream on restore fails if some key groups weren't written

2020-10-28 Thread GitBox
tzulitai edited a comment on pull request #13773: URL: https://github.com/apache/flink/pull/13773#issuecomment-717730004 @Antti-Kaikkonen thanks you for trying the branch out. I think the exceptions you encountered are expected in the experiments you've tried out. Can you

[GitHub] [flink] rmetzger merged pull request #13814: [FLINK-19839][e2e] Properly forward test exit code to CI system

2020-10-28 Thread GitBox
rmetzger merged pull request #13814: URL: https://github.com/apache/flink/pull/13814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] wangyang0918 commented on a change in pull request #13644: [FLINK-19542][k8s]Implement LeaderElectionService and LeaderRetrievalService based on Kubernetes API

2020-10-28 Thread GitBox
wangyang0918 commented on a change in pull request #13644: URL: https://github.com/apache/flink/pull/13644#discussion_r513210810 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/LeaderElectionEventHandler.java ## @@ -0,0 +1,49 @@ +/* + *

[GitHub] [flink] wangyang0918 commented on a change in pull request #13644: [FLINK-19542][k8s]Implement LeaderElectionService and LeaderRetrievalService based on Kubernetes API

2020-10-28 Thread GitBox
wangyang0918 commented on a change in pull request #13644: URL: https://github.com/apache/flink/pull/13644#discussion_r513218321 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java ## @@ -0,0 +1,92 @@ +/* + *

[GitHub] [flink] tzulitai edited a comment on pull request #13761: [FLINK-19741] Allow AbstractStreamOperator to skip restoring timers if subclasses are using raw keyed state

2020-10-28 Thread GitBox
tzulitai edited a comment on pull request #13761: URL: https://github.com/apache/flink/pull/13761#issuecomment-717743321 @pnowojski @banmoy Yes, I think it won't hurt to add checking the `isUsingCustomRawKeyedState` flag to the snapshot path of legacy raw keyed state timers. As of

[GitHub] [flink] wangyang0918 commented on a change in pull request #13644: [FLINK-19542][k8s]Implement LeaderElectionService and LeaderRetrievalService based on Kubernetes API

2020-10-28 Thread GitBox
wangyang0918 commented on a change in pull request #13644: URL: https://github.com/apache/flink/pull/13644#discussion_r513218189 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalDriver.java ## @@ -0,0 +1,195 @@ +/* + *

[GitHub] [flink] tzulitai commented on pull request #13761: [FLINK-19741] Allow AbstractStreamOperator to skip restoring timers if subclasses are using raw keyed state

2020-10-28 Thread GitBox
tzulitai commented on pull request #13761: URL: https://github.com/apache/flink/pull/13761#issuecomment-717743321 @pnowojski @banmoy Yes, I think it won't hurt to add checking the `isUsingCustomRawKeyedState` flag to the snapshot path of legacy raw keyed state timers. As of now, if

[GitHub] [flink] wuchong commented on pull request #13300: [FLINK-19077][table-runtime] Import process time temporal join operator.

2020-10-28 Thread GitBox
wuchong commented on pull request #13300: URL: https://github.com/apache/flink/pull/13300#issuecomment-717767478 Build is passed: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8452=results This is

[GitHub] [flink] wuchong edited a comment on pull request #13300: [FLINK-19077][table-runtime] Import process time temporal join operator.

2020-10-28 Thread GitBox
wuchong edited a comment on pull request #13300: URL: https://github.com/apache/flink/pull/13300#issuecomment-717767478 Build is passed: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8452=results Merging...

[GitHub] [flink] flinkbot commented on pull request #13817: [HotFix][docs] Fix broken link of docker.md

2020-10-28 Thread GitBox
flinkbot commented on pull request #13817: URL: https://github.com/apache/flink/pull/13817#issuecomment-717771629 ## CI report: * f7fcad2291f072819e6576b291327abd16947445 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] wuchong closed pull request #13815: [BP-1.11][FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

2020-10-28 Thread GitBox
wuchong closed pull request #13815: URL: https://github.com/apache/flink/pull/13815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Closed] (FLINK-18122) Kubernetes test fails with "error: timed out waiting for the condition on jobs/flink-job-cluster"

2020-10-28 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-18122. -- Fix Version/s: 1.12.0 Resolution: Fixed Improved test stability in

[jira] [Commented] (FLINK-19587) Error result when casting binary type as varchar

2020-10-28 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222029#comment-17222029 ] Jark Wu commented on FLINK-19587: - Hi [~hailong wang], I found it's not compatible to just cherry pick

[GitHub] [flink] rmetzger closed pull request #13779: [FLINK-18122][e2e] Make K8s test more resilient by retrying and failing docker iamge build

2020-10-28 Thread GitBox
rmetzger closed pull request #13779: URL: https://github.com/apache/flink/pull/13779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

<    1   2   3   4   5   6   >