[GitHub] flink pull request #2900: Rebased: Keytab & TLS support for Flink on Mesos S...

2016-11-29 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2900 Rebased: Keytab & TLS support for Flink on Mesos Setup Rebased #2734 to the latest master. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/f

[GitHub] flink issue #2900: Rebased: Keytab & TLS support for Flink on Mesos Setup

2016-11-30 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2900 Rebased again to the latest Mesos changes to make sure tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #2908: [maven] properly attach the CEP Scala source code

2016-11-30 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2908 [maven] properly attach the CEP Scala source code Two options, either change the default Maven source directory from 'src/main/java' to 'src/main/scala' or use the build-helper

[GitHub] flink issue #2900: Rebased: Keytab & TLS support for Flink on Mesos Setup

2016-11-30 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2900 Tests passed. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] flink pull request #2917: [FLINK-2821] use custom Akka build to listen on al...

2016-12-01 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2917 [FLINK-2821] use custom Akka build to listen on all interfaces This uses Flakka (a custom Akka 2.3 build) to resolve the issue that the bind address needs to be matching the external address of the

[GitHub] flink pull request #2908: [maven] properly attach the CEP Scala source code

2016-12-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2908#discussion_r90469083 --- Diff: flink-libraries/flink-cep-scala/pom.xml --- @@ -93,6 +93,8 @@ under the License. + +src/main/scala

[GitHub] flink pull request #2917: [FLINK-2821] use custom Akka build to listen on al...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2917#discussion_r90621698 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -1891,8 +1891,8 @@ object JobManager { // parsing

[GitHub] flink pull request #2917: [FLINK-2821] use custom Akka build to listen on al...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2917#discussion_r90621937 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -2729,11 +2727,11 @@ object JobManager { def

[GitHub] flink issue #2917: [FLINK-2821] use custom Akka build to listen on all inter...

2016-12-02 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2917 Thanks for checking out the code! >If different parts of the code or the JDK do a subtle change of behavior (i.e. resolve the InetAddress), then some nodes may have a hostname in the

[GitHub] flink pull request #2917: [FLINK-2821] use custom Akka build to listen on al...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2917#discussion_r90627441 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -1891,8 +1891,8 @@ object JobManager { // parsing

[GitHub] flink issue #2917: [FLINK-2821] use custom Akka build to listen on all inter...

2016-12-02 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2917 >Can we try and preserve both in some way? When a logical hostname is specified, we use that one in the Akka URLs. When an IP address is specified, we normalize it and use it. Detecting whet

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90666707 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/overlays/HadoopConfOverlayTest.java --- @@ -0,0 +1,119

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90665396 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/overlays/HadoopConfOverlayTest.java --- @@ -0,0 +1,119

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90664693 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/FlinkDistributionOverlay.java --- @@ -0,0 +1,126

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90664782 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/KeytabOverlay.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90664795 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/Krb5ConfOverlay.java --- @@ -0,0 +1,111 @@ +/* + * Licensed to

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90454802 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/AbstractContainerOverlay.java --- @@ -0,0 +1,72

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90664759 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/HadoopUserOverlay.java --- @@ -0,0 +1,83 @@ +/* + * Licensed to

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90666953 --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java --- @@ -542,42 +542,10 @@ protected static File

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90664938 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/SSLStoreOverlay.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90454287 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/ContainerOverlay.java --- @@ -0,0 +1,37 @@ +/* + * Licensed to

[GitHub] flink issue #2928: [FLINK-5108] Remove ClientShutdownHook during job executi...

2016-12-05 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2928 Thanks for the PR! This removes the shutdown hook after the cluster has been deployed. The original intend was to remove it only after job submission. Probably it makes sense to remove it all-together

[GitHub] flink pull request #2945: [FLINK-5262][docs] Introduce Gemfile.lock to avoid...

2016-12-05 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2945 [FLINK-5262][docs] Introduce Gemfile.lock to avoid dependency range conflicts The Gemfile for specifying the Ruby dependencies of our documentation has fixed dependency versions to avoid

[GitHub] flink issue #2945: [FLINK-5262][docs] Introduce Gemfile.lock to avoid depend...

2016-12-05 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2945 I've tested the changes through this build: https://ci.apache.org/builders/flink-docs-FLINK-3887/builds/36 --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] flink issue #2928: [FLINK-5108] Remove ClientShutdownHook during job executi...

2016-12-05 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2928 I think the original intend of the Client shutdown hook was to make sure that clusters which are spawned and didn't receive jobs are cleaned up again. However, that behavior can be quite tricky be

[GitHub] flink issue #2915: [FLINK-5091] Formalize the Mesos AppMaster environment fo...

2016-12-05 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2915 Looks really good!. Merging with some minor changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request #2951: [docs] clarify default restart behavior when check...

2016-12-06 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2951 [docs] clarify default restart behavior when checkpointing is enabled Merging this to `master` and `release-1.1`. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] flink issue #2954: [docs] Note that numberOfExecutionRetries and executionRe...

2016-12-07 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2954 Merged in c024b0b6cae16a0b668d864c77e923820c262087 but forgot to include the "This closes #2954" message in the commit, could you close the PR? --- If your project is set up for it, you ca

[GitHub] flink issue #2951: [docs] clarify default restart behavior when checkpointin...

2016-12-07 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2951 Sorry, I missed your comment. We can open another PR to clarify that! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request #2951: [docs] clarify default restart behavior when check...

2016-12-07 Thread mxm
Github user mxm closed the pull request at: https://github.com/apache/flink/pull/2951 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #2917: [FLINK-2821] use custom Akka build to listen on all inter...

2016-12-08 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2917 @StephanEwen I've updated the pull request to incorporate your suggestions. When an IPv6 address is specified, we format it like in the current code base. When a hostname is specified, we do some s

[GitHub] flink pull request #2981: [docker] improve Dockerfile host configuration

2016-12-09 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2981 [docker] improve Dockerfile host configuration - configure job manager address for both operation modes - introduce argument to specify the external job manager address - replace ARG with ENV

[GitHub] flink issue #2928: [FLINK-5108] Remove ClientShutdownHook during job executi...

2016-12-12 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2928 I will go ahead and merge this PR since there have been no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #2997: [FLINK-5240][tests] ensure state backends are prop...

2016-12-13 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2997 [FLINK-5240][tests] ensure state backends are properly closed This adds additional test cases to verify the state backends are closed properly upon the end of a task. The state backends should

[GitHub] flink issue #2928: [FLINK-5108] Remove ClientShutdownHook during job executi...

2016-12-13 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2928 There is one problem we overlooked. In detached mode we ensure cluster shutdown through a message sent by the client during job submission to tell the JobManager that this is going to be the last job it

[GitHub] flink pull request #3007: [FLINK-4922][docs] document how to use Flink on Me...

2016-12-14 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/3007 [FLINK-4922][docs] document how to use Flink on Mesos This adds some initial user documentation for Flink on Mesos. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] flink issue #2997: [FLINK-5240][tests] ensure state backends are properly cl...

2016-12-14 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2997 Thanks for the review, will merge then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2928: [FLINK-5108] Remove ClientShutdownHook during job executi...

2016-12-15 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2928 Thanks for your understanding :) Could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #3013: [FLINK-5344] relax spec for requested ruby version...

2016-12-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/3013#discussion_r92654203 --- Diff: docs/Gemfile --- @@ -17,13 +17,14 @@ source '

[GitHub] flink pull request #3013: [FLINK-5344] relax spec for requested ruby version...

2016-12-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/3013#discussion_r92653981 --- Diff: docs/build_docs.sh --- @@ -46,8 +46,8 @@ DOCS_DST=${DOCS_SRC}/content JEKYLL_CMD="build" # if -p flag is provided, ser

[GitHub] flink pull request #2917: [FLINK-2821] use custom Akka build to listen on al...

2016-12-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2917#discussion_r92658254 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala --- @@ -102,21 +102,24 @@ object AkkaUtils { * specified, then the

[GitHub] flink pull request #2917: [FLINK-2821] use custom Akka build to listen on al...

2016-12-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2917#discussion_r92658704 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala --- @@ -216,12 +219,19 @@ object AkkaUtils { * identified by

[GitHub] flink pull request #2917: [FLINK-2821] use custom Akka build to listen on al...

2016-12-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2917#discussion_r92659443 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala --- @@ -216,12 +219,19 @@ object AkkaUtils { * identified by

[GitHub] flink pull request #2917: [FLINK-2821] use custom Akka build to listen on al...

2016-12-15 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2917#discussion_r92661183 --- Diff: flink-runtime/pom.xml --- @@ -193,8 +193,8 @@ under the License. - com.typesafe.akka

[GitHub] flink issue #2917: [FLINK-2821] use custom Akka build to listen on all inter...

2016-12-15 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2917 Thanks you @tillrohrmann and @StephanEwen. I've addressed your comments. I'll have to redeploy Flakka because the staging repository which this PR used, has been dropped in the meantime. I w

[GitHub] flink issue #2917: [FLINK-2821] use custom Akka build to listen on all inter...

2016-12-15 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2917 I've added the new staging repository to test the PR changes. Also, the repository is currently deploying to Maven central. --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request #3017: [FLINK-5350] don't overwrite an existing JAAS conf...

2016-12-16 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/3017 [FLINK-5350] don't overwrite an existing JAAS config Users may want to use SASL/PLAIN https://tools.ietf.org/html/rfc4616 without Kerberos. You can merge this pull request into a Git reposito

[GitHub] flink issue #2917: [FLINK-2821] use custom Akka build to listen on all inter...

2016-12-16 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2917 Thank you, will go ahead and merge then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink issue #3016: [FLINK-5344] Fixed the dockerized doc build, which has be...

2016-12-16 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/3016 Thank you for fixing this, David! I have just verified that this fixes the Buildbot related issues. It is a shame that we only have Ruby 1.9, but for now we will have to deal with this limitation

[GitHub] flink issue #3016: [FLINK-5344] Fixed the dockerized doc build, which has be...

2016-12-16 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/3016 Had to add this to the root `pom.xml` to convince the Rat plugin to pass. ```xml docs/ruby2/Gemfile.lock ``` --- If your project is set up for it, you can reply

[GitHub] flink issue #3016: [FLINK-5344] Fixed the dockerized doc build, which has be...

2016-12-16 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/3016 @greghogan `docs/build_docs.sh` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #3017: [FLINK-5350] don't overwrite an existing JAAS config

2016-12-16 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/3017 Thank you @theomega. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink pull request #2147: [FLINK-1946] reduce verbosity of Yarn cluster setu...

2016-06-22 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2147 [FLINK-1946] reduce verbosity of Yarn cluster setup This removes repeated printing of messages retrieved from the Yarn cluster. Only new messages are printed. You can merge this pull request into a

[GitHub] flink issue #2138: [FLINK-3757] clarify JavaDoc for addAccumulator method

2016-06-25 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2138 Thank you for the suggestion. I incorporated it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68550160 --- Diff: docs/apis/cli.md --- @@ -187,6 +187,8 @@ Action "run" compiles and runs

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68550234 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68550224 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68550677 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -76,6 +76,9 @@ static final Option

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68550807 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java --- @@ -98,6 +98,12 @@ public void testRun

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68551023 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,6 +17,20 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68551210 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -33,6 +47,22 @@ while [ -L "$target" ]; do iteration=$((iteration + 1))

[GitHub] flink issue #2149: [FLINK-4084] Add configDir parameter to CliFrontend and f...

2016-06-27 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2149 Thanks for the pull request! I've made some comments. The pull requests also needs to be rebased against the latest master. --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request #2166: [FLINK-4099] Fix CliFrontendYarnAddressConfigurati...

2016-06-27 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2166#discussion_r68551820 --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java --- @@ -593,7 +593,12 @@ public void sendStop

[GitHub] flink pull request #2168: [FLINK-3964] add hint to job submission timeout ex...

2016-06-27 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2168 [FLINK-3964] add hint to job submission timeout exception message You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLINK-3964

[GitHub] flink issue #2166: [FLINK-4099] Fix CliFrontendYarnAddressConfigurationTest ...

2016-06-27 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2166 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2168: [FLINK-3964] add hint to job submission timeout exception...

2016-06-28 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2168 Thanks for the feedback. Savepoint related errors should be forwarded to the client independently of timeouts (except maybe when the savepoint takes too long). So that should be fixed in a follow-up

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68741402 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68741598 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68741918 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendRunTest.java --- @@ -100,15 +100,22 @@ public void testRun

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742023 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742138 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742191 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68742325 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-28 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68746527 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68905457 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -269,26 +269,26 @@ * Percentage of heap space to remove

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68905471 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -269,26 +269,26 @@ * Percentage of heap space to remove

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68905882 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -269,26 +269,26 @@ * Percentage of heap space to remove

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68905853 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -269,26 +269,26 @@ * Percentage of heap space to remove

[GitHub] flink issue #2177: [FLINK-4127] Check API compatbility for 1.1 in flink-core

2016-06-29 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2177 Thanks for updating the documentation! I've made some suggestions regarding the names of the new configuration keys. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r68908671 --- Diff: docs/setup/config.md --- @@ -107,12 +109,20 @@ Please make sure to set the maximum ticket life span high long running jobs. The If you are

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r68910391 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink pull request #2187: [FLINK-3675][yarn] improvements to library shippin...

2016-06-29 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2187 [FLINK-3675][yarn] improvements to library shipping - always ship the lib folder - properly setup the classpath from the supplied ship files - cleanup deploy() method of YarnClusterDescriptor

[GitHub] flink issue #2187: [FLINK-3675][yarn] improvements to library shipping

2016-06-30 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2187 I moved one existing environment variable `FLINK_CONF_DIR` to `ConfigConstants`. I added the `FLINK_LIB_DIR` environment variable to load a library folder (optional). I'm not sure whether we shoul

[GitHub] flink issue #2187: [FLINK-3675][yarn] improvements to library shipping

2016-06-30 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2187 All builds are passing in my branch: https://travis-ci.org/mxm/flink/builds/141155293 CC @rmetzger --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69101854 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -132,9 +132,9 @@ - private final Configuration

[GitHub] flink issue #2149: [FLINK-4084] Add configDir parameter to CliFrontend and f...

2016-06-30 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2149 Thanks for the update. We're getting there :) Great work so far! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69101922 --- Diff: flink-dist/src/main/flink-bin/bin/flink --- @@ -17,20 +17,41 @@ # limitations under the License

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69123278 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -459,4 +476,14 @@ public static InfoOptions parseInfoCommand

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69123376 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java --- @@ -0,0 +1,35 @@ +package org.apache.flink.client

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69123415 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java --- @@ -0,0 +1,35 @@ +package org.apache.flink.client

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r69123467 --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java --- @@ -0,0 +1,35 @@ +package org.apache.flink.client

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r69123978 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -269,26 +269,26 @@ * Percentage of heap space to remove

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-06-30 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r69124072 --- Diff: docs/setup/config.md --- @@ -230,8 +240,8 @@ definition. This scheme is used **ONLY** if no other scheme is specified (explic ## YARN

[GitHub] flink pull request #2189: [FLINK-3667] delay connection to JobManager until ...

2016-06-30 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2189 [FLINK-3667] delay connection to JobManager until job execution - lazily initialize ActorSystem - make sure it is not created before job execution - print connection information on the CLI You

[GitHub] flink issue #2189: [FLINK-3667] delay connection to JobManager until job exe...

2016-07-01 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2189 Sorry, didn't see your comments. The test failures should be resolved (I ran `mvn verify`). The changes delay the creation of the ActorSystem and thus any blocking actions until we

[GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...

2016-07-01 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2177#discussion_r69300607 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -269,26 +269,26 @@ * Percentage of heap space to remove

[GitHub] flink pull request #2190: [FLINK-4141] remove leaderUpdated() method from Re...

2016-07-01 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2190 [FLINK-4141] remove leaderUpdated() method from ResourceManager This removes the leaderUpdated method from the framework. Further it lets the RM client thread communicate directly with the

[GitHub] flink pull request #2191: [FLINK-4144] Yarn properties file: replace hostnam...

2016-07-01 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2191 [FLINK-4144] Yarn properties file: replace hostname/port with Yarn application id You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLINK

[GitHub] flink issue #2149: [FLINK-4084] Add configDir parameter to CliFrontend and f...

2016-07-18 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2149 @alkagin I've been on vacations. Getting back to you soon! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-18 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71122579 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -405,36 +374,13 @@ class JobManager

<    1   2   3   4   5   6   7   8   9   10   >