Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2054#discussion_r65328505
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2057
[hotfix] Fix JSONDeserializationSchema for Kafka; ParameterTool usability
The JSONDeserializationSchema was implementing the
KeyedDeserializationSchema. However, it was not using the key or any
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2133
Just verified the fix.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2148
[FLINK-3995] [build] Make test utils properly available and fix Maven
dependencies
This pull request subsumes https://github.com/apache/flink/pull/2092.
I added a commit to Stephan's pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2142#discussion_r68060615
--- Diff: docs/apis/streaming/connectors/kafka.md ---
@@ -198,6 +198,63 @@ Flink on YARN supports automatic restart of lost YARN
containers
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2142#discussion_r68061306
--- Diff: docs/apis/streaming/connectors/kafka.md ---
@@ -198,6 +198,63 @@ Flink on YARN supports automatic restart of lost YARN
containers
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2142
Thank you for opening the pull request.
There's one issue that needs addressing, once that's done, we can merge it.
---
If your project is set up for it, you can reply to this email and have
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2142
Okay, merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2108#discussion_r68082639
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2108
[FLINK-4027] Flush FlinkKafkaProducer on checkpoints
A user on the mailing list raised the point that our Kafka producer can be
made at-least-once quite easily.
The current producer code
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2114
Thank you for your contribution. There is a typo in the pull request title.
its important that its correct so that our jira picks up the pull request.
Please also check out our contribution
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2151
[hotfix][docs] Add warning to Cassandra documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink cassandra_doc_hotfix
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2153
[FLINK-4110] Add testing skeleton to quickstart
With this change, our quickstart archetypes will also contain some sample
code for bringing up an embedded server for testing purposes.
You can
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2092#discussion_r67688097
--- Diff: flink-scala-shell/pom.xml ---
@@ -70,27 +71,19 @@ under the License.
scala-library
${scala.version
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2092
I quickly looked through the changed files. I think the changes are okay.
However, it seems that the the pull request doesn't build (and merge with
master). I've started addressing those issues
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2075
Thanks a lot for opening a pull request for this.
I like having virtual machines and deployment available for new projects,
so in general I like the idea a lot.
However, I wonder
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2085
I tried your code again on my testing machine and everything that didn't
work at my last tests is now fixed.
I also quickly scanned the newly added commits.
I think the pull request
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2108
Thank you for the review @eliaslevy!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399389
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/IKinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399431
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399467
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68400596
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/IKinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68403594
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68404148
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68406625
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68397478
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68400657
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68403918
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68399454
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68402254
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
I'll review your change now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2071#discussion_r68386857
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumerThread.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68413466
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68410216
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
Okay, sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2071
Yes, I would suggest to do this PR after the big one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
I'm not done with the review yet. I hope I find some time over the weekend
to continue with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1512#discussion_r49876047
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/FoldWindowFunctionTest.java
---
@@ -66,10 +72,27 @@ public Integer
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1492#issuecomment-171596184
Thank you for the reviews ... I'll merge the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1513#issuecomment-172533529
I think the documentation hasn't been adopted to the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1515#issuecomment-172527568
-1 breaks build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1489#issuecomment-171903718
Okay, I'll rename the consumers and producers to include the version.
(FlinkKafkaConsumer08 and so on.)
---
If your project is set up for it, you can reply
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68594061
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68722233
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68726797
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
I'm done with my first full review. I'll test the code tomorrow.
Let me know if you need help addressing my comments.
---
If your project is set up for it, you can reply to this email and have
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68727843
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68729145
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2175
[FLINK-4085][Kinesis] Set Flink-specific user agent
I was asked by Amazon to set a Flink specific user agent when accessing the
AWS APIs.
I've set an agent for the consumer, for the producer I
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68454370
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,232
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/1813
@mjsax, did you test the code with a redis installation / on a cluster?
(I'm not expecting those tests from a PR review, but I would not do it again if
you already did ... and I'm not doing
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68455334
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSentinelClusterTest.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68455277
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSentinelClusterTest.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68453882
--- Diff: flink-streaming-connectors/flink-connector-redis/pom.xml ---
@@ -0,0 +1,92 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68455103
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68454693
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68453630
--- Diff: flink-streaming-connectors/flink-connector-redis/pom.xml ---
@@ -0,0 +1,92 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68454559
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2108#discussion_r67296678
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2180
Thanks a lot for fixing this. I'll try to review it in the next few hours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r68904915
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,211 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2180#discussion_r68906667
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/SequenceNumber.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r68906518
--- Diff: docs/setup/config.md ---
@@ -85,6 +85,8 @@ The default fraction for managed memory can be adjusted
using the `taskmanager.m
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r68904562
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,211 @@ You may specify program arguments before the job is
executed. The plan visualiza
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2180#discussion_r68905535
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/SequenceNumber.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1513#discussion_r52185124
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -163,7 +166,11 @@ public KeyedStream
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1513#discussion_r52184878
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/TimeCharacteristic.java
---
@@ -34,7 +34,7 @@
* because the contents
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1584
[FLINK-3328] Incorrectly shaded dependencies in flink-runtime
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3328
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-180422247
Awesome, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1588#discussion_r52101633
--- Diff: docs/setup/config.md ---
@@ -211,6 +211,8 @@ The parameters define the behavior of tasks that create
result files
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-180753220
I hope its a coincidence that the YARN tests failed in this PR. If they
fail after your next push again, we have to check if your changes caused the
failure
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-180753150
I didn't test this myself, but this diff could be sufficient for testing
your change:
```diff
diff --git
a/flink-yarn-tests/src/main/java/org/apache/flink
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-180746275
How do you want to implement this? I'm asking because I don't see an
obvious way to expose this to the user.
---
If your project is set up for it, you can reply
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1597
[FLINK-3341] Make 'auto.offset.reset' compatible with Kafka 0.8 and 0.9
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-180994099
The first test failed because some files on travis were corrupted, the two
other tests failed probably because the YARN tests became unstable recently.
I think
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1597#discussion_r52202024
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/LegacyFetcher.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-179859441
I just checked out your pull request locally and looked through it.
I think the following things need to be fixed before we can merge it:
- Squash the 60
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1584#issuecomment-179866261
It works with CDH 5.4.2, which uses Hadoop 2.6.0.
I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1581#discussion_r51874764
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/distcp/DistCp.java
---
@@ -62,18 +63,32 @@
public static
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-183314810
Once this PR has been merged (I expect that some adoptions might still be
required) I can try and see if its straightforward to backport. Are you
planning to stick
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-183288223
Thank you.
- ` ./bin/yarn-session.sh -tm 1024 -n 7 -s 2 -Dfs.default-scheme=hdfs:///`
is now working
- Setting the fs.default-scheme to `thisIsWrong
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1606#issuecomment-183332749
Except for two questions, the PR looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1563#issuecomment-183356403
Thank you for the review. I've addressed the comments and rebased the
change.
Once travis has passed, I'll merge it!
---
If your project is set up
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52386582
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385415
--- Diff: docs/apis/batch/index.md ---
@@ -2123,7 +2123,7 @@ Note that types registered with `registerKryoType()`
are not available to Flink
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385934
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385223
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
---
@@ -27,13 +24,17 @@
import
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385698
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
---
@@ -141,9 +146,16 @@ public
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385188
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
---
@@ -75,16 +76,22 @@ public void
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52386295
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1607#issuecomment-182114169
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182065768
I identified the following issues:
- Setting the configuration using the yarn session "dynamic properties":
`./bin/yarn-session.sh -n 2 -Dfs.defa
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52388115
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java
---
@@ -0,0 +1,175
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182066864
Setting the value to `fs.default-scheme: thisIsWrong:///`
is good:
```
robert@cdh544-master:~/flink/build-target$ ./bin/flink run
./examples/batch
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182054657
I'm testing the change on a cluster (with YARN) to see if everything is
working as expected.
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1605#issuecomment-182125713
You are adding new `.apply()` variants to the API which are not documented
with the PR.
---
If your project is set up for it, you can reply to this email and have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1428#issuecomment-179926670
I went through all the classes in the relevant modules outside `flink-core`
with @fhueske and annotated them properly.
I've rebased the changes and checked
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1590#issuecomment-180283281
Looks like one test needs to be adopted
```
testCheckpointing(org.apache.flink.streaming.connectors.kafka.Kafka08ITCase)
Time elapsed: 0.194 sec
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1590#issuecomment-180038020
Change looks good.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-180378937
Actually, I worked a bit with redis recently ;) I'll take a look at the PR
now.
---
If your project is set up for it, you can reply to this email and have your
reply
1101 - 1200 of 2231 matches
Mail list logo
